Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 45684cc85f9f3fbdd873b03a237528d3433e6138
https://github.com/WebKit/WebKit/commit/45684cc85f9f3fbdd873b03a237528d3433e6138
Author: David Kilzer <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M Source/WebCore/style/MatchedDeclarationsCache.cpp
Log Message:
-----------
[CSS] Crash due to release assert in HashTable when
MatchedDeclarationsCache::computeHash() returns 0xFFFFFFFF
<https://bugs.webkit.org/show_bug.cgi?id=305864>
<rdar://118164567>
Reviewed by Chris Dumez.
MatchedDeclarationsCache::computeHash() calls avalancheBits(hash) to
compute a hash, which may return the deleted value. This would lead to
the release assert firing when attempting to add the deleted value to a
HashTable.
The fix is to call AlreadyHashed::avoidDeletedValue() to avoid using the
deleted value as a hash key.
No new tests since this hash key is computed using the value of pointers
to memory addresses, and thus is nondeterministic.
* Source/WebCore/style/MatchedDeclarationsCache.cpp:
(WebCore::Style::MatchedDeclarationsCache::computeHash):
- Use WTF::AlreadyHashed::avoidDeletedValue() to avoid returning the
value of a deleted hash table entry.
Canonical link: https://commits.webkit.org/305989@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications