Title: [114020] trunk
Revision
114020
Author
[email protected]
Date
2012-04-12 12:54:21 -0700 (Thu, 12 Apr 2012)

Log Message

[CSS Exclusions] Add flag to enable / disable exclusions at runtime
https://bugs.webkit.org/show_bug.cgi?id=83313

Patch by Bear Travis <[email protected]> on 2012-04-12
Reviewed by Ryosuke Niwa.

.:

Adding the GTK symbols

* Source/autotools/symbols.filter:

Source/WebCore:

Adding setCSSExclusionsEnabled/cssExclusionsEnabled that is true by default.
The CSS parser will not accept values for the exclusions properties when
cssExclusionsEnabled is false. However, you will still get the default value
in the computed style.

Test: fast/exclusions/css-exclusions-disabled.html

* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
(RuntimeEnabledFeatures):
* css/CSSParser.cpp:
(WebCore::isSimpleLengthValue):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setCSSExclusionsEnabled):
(WebCore):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

Source/WebKit2:

Adding windows symbols

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Adding a test to cover CSS parsing, which is the only piece of exclusions
work in place. Updating other exclusions test to explicitly enable the
feature.

* fast/exclusions/css-exclusions-disabled-expected.txt: Added.
* fast/exclusions/css-exclusions-disabled.html: Added.
* fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
* fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
* fast/exclusions/script-tests/wrap-flow-parsing.js:
* fast/exclusions/script-tests/wrap-margin-parsing.js:
* fast/exclusions/script-tests/wrap-padding-parsing.js:
* fast/exclusions/script-tests/wrap-parsing.js:
* fast/exclusions/script-tests/wrap-through-parsing.js:

Modified Paths

Added Paths

Diff

Modified: trunk/ChangeLog (114019 => 114020)


--- trunk/ChangeLog	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/ChangeLog	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,3 +1,14 @@
+2012-04-12  Bear Travis  <[email protected]>
+
+        [CSS Exclusions] Add flag to enable / disable exclusions at runtime
+        https://bugs.webkit.org/show_bug.cgi?id=83313
+
+        Reviewed by Ryosuke Niwa.
+
+        Adding the GTK symbols
+
+        * Source/autotools/symbols.filter:
+
 2012-04-12  George Staikos  <[email protected]>
 
         Enable the fullscreen API for BlackBerry.

Modified: trunk/LayoutTests/ChangeLog (114019 => 114020)


--- trunk/LayoutTests/ChangeLog	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/LayoutTests/ChangeLog	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,3 +1,24 @@
+2012-04-12  Bear Travis  <[email protected]>
+
+        [CSS Exclusions] Add flag to enable / disable exclusions at runtime
+        https://bugs.webkit.org/show_bug.cgi?id=83313
+
+        Reviewed by Ryosuke Niwa.
+
+        Adding a test to cover CSS parsing, which is the only piece of exclusions
+        work in place. Updating other exclusions test to explicitly enable the
+        feature.
+
+        * fast/exclusions/css-exclusions-disabled-expected.txt: Added.
+        * fast/exclusions/css-exclusions-disabled.html: Added.
+        * fast/exclusions/script-tests/parsing-wrap-shape-inside.js:
+        * fast/exclusions/script-tests/parsing-wrap-shape-outside.js:
+        * fast/exclusions/script-tests/wrap-flow-parsing.js:
+        * fast/exclusions/script-tests/wrap-margin-parsing.js:
+        * fast/exclusions/script-tests/wrap-padding-parsing.js:
+        * fast/exclusions/script-tests/wrap-parsing.js:
+        * fast/exclusions/script-tests/wrap-through-parsing.js:
+
 2012-04-12  Stephen Chenney  <[email protected]>
 
         [Chromium] Layout test svg/text/font-size-below-point-five.svg needs rebaseline

Added: trunk/LayoutTests/fast/exclusions/css-exclusions-disabled-expected.txt (0 => 114020)


--- trunk/LayoutTests/fast/exclusions/css-exclusions-disabled-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/exclusions/css-exclusions-disabled-expected.txt	2012-04-12 19:54:21 UTC (rev 114020)
@@ -0,0 +1,21 @@
+Test that parsing of css exclusions related properties can be disabled.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS testInlineStyle("-webkit-wrap-flow", "both") is null
+PASS testComputedStyle("-webkit-wrap-flow", "both") is "auto"
+PASS testInlineStyle("-webkit-wrap-margin", "10px") is null
+PASS testComputedStyle("-webkit-wrap-margin", "10px") is "0px"
+PASS testInlineStyle("-webkit-wrap-padding", "10px") is null
+PASS testComputedStyle("-webkit-wrap-padding", "10px") is "0px"
+PASS testInlineStyle("-webkit-wrap-through", "none") is null
+PASS testComputedStyle("-webkit-wrap-through", "none") is "wrap"
+PASS testInlineStyle("-webkit-shape-outside", "circle(10px, 10px, 10px)") is null
+PASS testComputedStyle("-webkit-shape-outside", "circle(10px, 10px, 10px)") is "auto"
+PASS testInlineStyle("-webkit-shape-inside", "circle(10px, 10px, 10px)") is null
+PASS testComputedStyle("-webkit-shape-inside", "circle(10px, 10px, 10px)") is "auto"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/exclusions/css-exclusions-disabled.html (0 => 114020)


--- trunk/LayoutTests/fast/exclusions/css-exclusions-disabled.html	                        (rev 0)
+++ trunk/LayoutTests/fast/exclusions/css-exclusions-disabled.html	2012-04-12 19:54:21 UTC (rev 114020)
@@ -0,0 +1,46 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+
+description('Test that parsing of css exclusions related properties can be disabled.');
+
+internals.settings.setCSSExclusionsEnabled(false);
+
+function testInlineStyle(property, value) {
+    var div = document.createElement("div");
+    div.setAttribute("style", property + ": " + value);
+    return div.style.getPropertyValue(property);
+}
+
+function testComputedStyle(property, value) {
+    var div = document.createElement("div");
+    document.body.appendChild(div);
+    div.style.setProperty(property, value);
+    var computedValue = getComputedStyle(div).getPropertyValue(property);
+    document.body.removeChild(div);
+    return computedValue;
+}
+
+function testStyle(property, value, computedExpected) {
+    shouldBeNull('testInlineStyle("' + property + '", "' + value + '")');
+    shouldBeEqualToString('testComputedStyle("' + property + '", "' + value + '")', computedExpected);
+}
+
+testStyle("-webkit-wrap-flow", "both", "auto");
+
+testStyle("-webkit-wrap-margin", "10px", "0px");
+testStyle("-webkit-wrap-padding", "10px", "0px");
+
+testStyle("-webkit-wrap-through", "none", "wrap");
+
+testInlineStyle("-webkit-wrap", "both 10px 10px");
+
+testStyle("-webkit-shape-outside", "circle(10px, 10px, 10px)", "auto");
+testStyle("-webkit-shape-inside", "circle(10px, 10px, 10px)", "auto");
+
+</script>
+<script src=""
+</body>
+</html>

Modified: trunk/LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-inside.js (114019 => 114020)


--- trunk/LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-inside.js	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-inside.js	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,5 +1,7 @@
 description('Testing the parsing of the -webkit-shape-inside property.');
 
+internals.settings.setCSSExclusionsEnabled(true);
+
 function testCSSText(declaration, expected)
 {
     var element = document.createElement("div");

Modified: trunk/LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-outside.js (114019 => 114020)


--- trunk/LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-outside.js	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/LayoutTests/fast/exclusions/script-tests/parsing-wrap-shape-outside.js	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,5 +1,7 @@
 description('Testing the parsing of the -webkit-shape-outside property.');
 
+internals.settings.setCSSExclusionsEnabled(true);
+
 function testCSSText(declaration, expected)
 {
     var element = document.createElement("div");

Modified: trunk/LayoutTests/fast/exclusions/script-tests/wrap-flow-parsing.js (114019 => 114020)


--- trunk/LayoutTests/fast/exclusions/script-tests/wrap-flow-parsing.js	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/LayoutTests/fast/exclusions/script-tests/wrap-flow-parsing.js	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,5 +1,7 @@
 description('Test parsing of the CSS wrap-flow property.');
 
+internals.settings.setCSSExclusionsEnabled(true);
+
 function test(declaration) {
     var div = document.createElement("div");
     div.setAttribute("style", declaration);

Modified: trunk/LayoutTests/fast/exclusions/script-tests/wrap-margin-parsing.js (114019 => 114020)


--- trunk/LayoutTests/fast/exclusions/script-tests/wrap-margin-parsing.js	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/LayoutTests/fast/exclusions/script-tests/wrap-margin-parsing.js	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,5 +1,7 @@
 description('Test parsing of the CSS wrap-margin property.');
 
+internals.settings.setCSSExclusionsEnabled(true);
+
 function test(declaration) {
     var div = document.createElement("div");
     div.setAttribute("style", declaration);

Modified: trunk/LayoutTests/fast/exclusions/script-tests/wrap-padding-parsing.js (114019 => 114020)


--- trunk/LayoutTests/fast/exclusions/script-tests/wrap-padding-parsing.js	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/LayoutTests/fast/exclusions/script-tests/wrap-padding-parsing.js	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,5 +1,7 @@
 description('Test parsing of the CSS wrap-padding property.');
 
+internals.settings.setCSSExclusionsEnabled(true);
+
 function test(declaration) {
     var div = document.createElement("div");
     div.setAttribute("style", declaration);

Modified: trunk/LayoutTests/fast/exclusions/script-tests/wrap-parsing.js (114019 => 114020)


--- trunk/LayoutTests/fast/exclusions/script-tests/wrap-parsing.js	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/LayoutTests/fast/exclusions/script-tests/wrap-parsing.js	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,5 +1,7 @@
 description('Test parsing of the CSS wrap property.');
 
+internals.settings.setCSSExclusionsEnabled(true);
+
 function test(declaration) {
     var div = document.createElement("div");
     div.setAttribute("style", declaration);

Modified: trunk/LayoutTests/fast/exclusions/script-tests/wrap-through-parsing.js (114019 => 114020)


--- trunk/LayoutTests/fast/exclusions/script-tests/wrap-through-parsing.js	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/LayoutTests/fast/exclusions/script-tests/wrap-through-parsing.js	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,5 +1,7 @@
 description('Test parsing of the CSS wrap-through property.');
 
+internals.settings.setCSSExclusionsEnabled(true);
+
 function test(declaration) {
     var div = document.createElement("div");
     div.setAttribute("style", declaration);

Modified: trunk/Source/WebCore/ChangeLog (114019 => 114020)


--- trunk/Source/WebCore/ChangeLog	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebCore/ChangeLog	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,3 +1,37 @@
+2012-04-12  Bear Travis  <[email protected]>
+
+        [CSS Exclusions] Add flag to enable / disable exclusions at runtime
+        https://bugs.webkit.org/show_bug.cgi?id=83313
+
+        Reviewed by Ryosuke Niwa.
+
+        Adding setCSSExclusionsEnabled/cssExclusionsEnabled that is true by default.
+        The CSS parser will not accept values for the exclusions properties when
+        cssExclusionsEnabled is false. However, you will still get the default value
+        in the computed style.
+
+        Test: fast/exclusions/css-exclusions-disabled.html
+
+        * WebCore.exp.in:
+        * bindings/generic/RuntimeEnabledFeatures.cpp:
+        (WebCore):
+        * bindings/generic/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
+        (WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
+        (RuntimeEnabledFeatures):
+        * css/CSSParser.cpp:
+        (WebCore::isSimpleLengthValue):
+        (WebCore::isValidKeywordPropertyAndValue):
+        (WebCore::CSSParser::parseValue):
+        * testing/InternalSettings.cpp:
+        (WebCore::InternalSettings::InternalSettings):
+        (WebCore::InternalSettings::restoreTo):
+        (WebCore::InternalSettings::setCSSExclusionsEnabled):
+        (WebCore):
+        * testing/InternalSettings.h:
+        (InternalSettings):
+        * testing/InternalSettings.idl:
+
 2012-04-12  Nate Chapin  <[email protected]>
 
         Move Archive processing to DocumentLoader, instead of FrameLoader.

Modified: trunk/Source/WebCore/WebCore.exp.in (114019 => 114020)


--- trunk/Source/WebCore/WebCore.exp.in	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebCore/WebCore.exp.in	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1171,6 +1171,7 @@
 __ZN7WebCore11BitmapImageC1EPNS_13ImageObserverE
 __ZN7WebCore11JSDOMWindow6s_infoE
 __ZN7WebCore5Image7setDataEN3WTF10PassRefPtrINS_12SharedBufferEEEb
+__ZN7WebCore22RuntimeEnabledFeatures22isCSSExclusionsEnabledE
 __ZNK3JSC8Bindings10RootObject12globalObjectEv
 __ZNK3WTF6String14createCFStringEv
 __ZNK7WebCore4Node9treeScopeEv

Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp (114019 => 114020)


--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp	2012-04-12 19:54:21 UTC (rev 114020)
@@ -55,6 +55,7 @@
 bool RuntimeEnabledFeatures::isDeviceMotionEnabled = true;
 bool RuntimeEnabledFeatures::isDeviceOrientationEnabled = true;
 bool RuntimeEnabledFeatures::isSpeechInputEnabled = true;
+bool RuntimeEnabledFeatures::isCSSExclusionsEnabled = false;
 
 #if ENABLE(SCRIPTED_SPEECH)
 bool RuntimeEnabledFeatures::isScriptedSpeechEnabled = false;

Modified: trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h (114019 => 114020)


--- trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h	2012-04-12 19:54:21 UTC (rev 114020)
@@ -70,6 +70,9 @@
     static bool webkitIDBRequestEnabled() { return isIndexedDBEnabled; }
     static bool webkitIDBTransactionEnabled() { return isIndexedDBEnabled; }
 
+    static void setCSSExclusionsEnabled(bool isEnabled) { isCSSExclusionsEnabled = isEnabled; }
+    static bool cssExclusionsEnabled() { return isCSSExclusionsEnabled; }
+
 #if ENABLE(FULLSCREEN_API)
     // Mozilla version
     static bool webkitFullScreenAPIEnabled() { return isFullScreenAPIEnabled; }
@@ -242,6 +245,7 @@
     static bool isDeviceMotionEnabled;
     static bool isDeviceOrientationEnabled;
     static bool isSpeechInputEnabled;
+    static bool isCSSExclusionsEnabled;
 #if ENABLE(SCRIPTED_SPEECH)
     static bool isScriptedSpeechEnabled;
 #endif

Modified: trunk/Source/WebCore/css/CSSParser.cpp (114019 => 114020)


--- trunk/Source/WebCore/css/CSSParser.cpp	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2012-04-12 19:54:21 UTC (rev 114020)
@@ -71,6 +71,7 @@
 #include "Pair.h"
 #include "Rect.h"
 #include "RenderTheme.h"
+#include "RuntimeEnabledFeatures.h"
 #include "Settings.h"
 #include "ShadowValue.h"
 #include "StylePropertySet.h"
@@ -368,10 +369,12 @@
     case CSSPropertyWebkitPaddingBefore:
     case CSSPropertyWebkitPaddingEnd:
     case CSSPropertyWebkitPaddingStart:
+        acceptsNegativeNumbers = false;
+        return true;
     case CSSPropertyWebkitWrapMargin:
     case CSSPropertyWebkitWrapPadding:
         acceptsNegativeNumbers = false;
-        return true;
+        return RuntimeEnabledFeatures::cssExclusionsEnabled();
     case CSSPropertyBottom:
     case CSSPropertyLeft:
     case CSSPropertyMarginBottom:
@@ -753,10 +756,14 @@
             return true;
         break;
     case CSSPropertyWebkitWrapFlow:
+        if (!RuntimeEnabledFeatures::cssExclusionsEnabled())
+            return false;
         if (valueID == CSSValueAuto || valueID == CSSValueBoth || valueID == CSSValueStart || valueID == CSSValueEnd || valueID == CSSValueMaximum || valueID == CSSValueClear)
             return true;
         break;
     case CSSPropertyWebkitWrapThrough:
+        if (!RuntimeEnabledFeatures::cssExclusionsEnabled())
+            return false;
         if (valueID == CSSValueWrap || valueID == CSSValueNone)
             return true;
         break;
@@ -2381,6 +2388,8 @@
 
     case CSSPropertyWebkitShapeInside:
     case CSSPropertyWebkitShapeOutside:
+        if (!RuntimeEnabledFeatures::cssExclusionsEnabled())
+            return false;
         if (id == CSSValueAuto)
             validPrimitive = true;
         else if (value->unit == CSSParserValue::Function)
@@ -2388,10 +2397,10 @@
         break;
     case CSSPropertyWebkitWrapMargin:
     case CSSPropertyWebkitWrapPadding:
-        validPrimitive = (!id && validUnit(value, FLength | FNonNeg));
+        validPrimitive = (RuntimeEnabledFeatures::cssExclusionsEnabled() && !id && validUnit(value, FLength | FNonNeg));
         break;
     case CSSPropertyWebkitWrap:
-        return parseShorthand(propId, webkitWrapShorthand(), important);
+        return RuntimeEnabledFeatures::cssExclusionsEnabled() && parseShorthand(propId, webkitWrapShorthand(), important);
     case CSSPropertyBorderBottomStyle:
     case CSSPropertyBorderCollapse:
     case CSSPropertyBorderLeftStyle:

Modified: trunk/Source/WebCore/testing/InternalSettings.cpp (114019 => 114020)


--- trunk/Source/WebCore/testing/InternalSettings.cpp	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebCore/testing/InternalSettings.cpp	2012-04-12 19:54:21 UTC (rev 114020)
@@ -94,11 +94,10 @@
     : FrameDestructionObserver(frame)
     , m_originalPasswordEchoDurationInSeconds(settings()->passwordEchoDurationInSeconds())
     , m_originalPasswordEchoEnabled(settings()->passwordEchoEnabled())
+    , m_originalCSSExclusionsEnabled(RuntimeEnabledFeatures::cssExclusionsEnabled())
 #if ENABLE(SHADOW_DOM)
     , m_originalShadowDOMEnabled(RuntimeEnabledFeatures::shadowDOMEnabled())
 #endif
-
-
 {
 }
 
@@ -106,6 +105,7 @@
 {
     settings->setPasswordEchoDurationInSeconds(m_originalPasswordEchoDurationInSeconds);
     settings->setPasswordEchoEnabled(m_originalPasswordEchoEnabled);
+    RuntimeEnabledFeatures::setCSSExclusionsEnabled(m_originalCSSExclusionsEnabled);
 #if ENABLE(SHADOW_DOM)
     RuntimeEnabledFeatures::setShadowDOMEnabled(m_originalShadowDOMEnabled);
 #endif
@@ -317,4 +317,9 @@
 #endif
 }
 
+void InternalSettings::setCSSExclusionsEnabled(bool enabled, ExceptionCode& ec)
+{
+    UNUSED_PARAM(ec);
+    RuntimeEnabledFeatures::setCSSExclusionsEnabled(enabled);
 }
+}

Modified: trunk/Source/WebCore/testing/InternalSettings.h (114019 => 114020)


--- trunk/Source/WebCore/testing/InternalSettings.h	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebCore/testing/InternalSettings.h	2012-04-12 19:54:21 UTC (rev 114020)
@@ -72,6 +72,7 @@
     void setPictographFontFamily(const String& family, const String& script, ExceptionCode&);
     void setEnableScrollAnimator(bool enabled, ExceptionCode&);
     bool scrollAnimatorEnabled(ExceptionCode&);
+    void setCSSExclusionsEnabled(bool enabled, ExceptionCode&);
 
     void restoreTo(Settings*);
 
@@ -84,6 +85,7 @@
 
     double m_originalPasswordEchoDurationInSeconds;
     bool m_originalPasswordEchoEnabled;
+    bool m_originalCSSExclusionsEnabled;
 #if ENABLE(SHADOW_DOM)
     bool m_originalShadowDOMEnabled;
 #endif

Modified: trunk/Source/WebCore/testing/InternalSettings.idl (114019 => 114020)


--- trunk/Source/WebCore/testing/InternalSettings.idl	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebCore/testing/InternalSettings.idl	2012-04-12 19:54:21 UTC (rev 114020)
@@ -51,6 +51,7 @@
         void setPictographFontFamily(in DOMString family, in DOMString script) raises(DOMException);
         void setEnableScrollAnimator(in boolean enabled) raises(DOMException);
         boolean scrollAnimatorEnabled() raises(DOMException);
+        void setCSSExclusionsEnabled(in boolean enabled) raises(DOMException);
     };
 }
 

Modified: trunk/Source/WebKit2/ChangeLog (114019 => 114020)


--- trunk/Source/WebKit2/ChangeLog	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebKit2/ChangeLog	2012-04-12 19:54:21 UTC (rev 114020)
@@ -1,3 +1,15 @@
+2012-04-12  Bear Travis  <[email protected]>
+
+        [CSS Exclusions] Add flag to enable / disable exclusions at runtime
+        https://bugs.webkit.org/show_bug.cgi?id=83313
+
+        Reviewed by Ryosuke Niwa.
+
+        Adding windows symbols
+
+        * win/WebKit2.def:
+        * win/WebKit2CFLite.def:
+
 2012-04-12  Yael Aharon  <[email protected]>
 
         [Qt][WK2] Nested fixed elements scroll too fast

Modified: trunk/Source/WebKit2/win/WebKit2.def (114019 => 114020)


--- trunk/Source/WebKit2/win/WebKit2.def	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebKit2/win/WebKit2.def	2012-04-12 19:54:21 UTC (rev 114020)
@@ -177,6 +177,7 @@
         ?getLocationAndLengthFromRange@TextIterator@WebCore@@SA_NPAVElement@2@PBVRange@2@AAI2@Z
         ?hasShadowRoot@Element@WebCore@@QBE_NXZ
         ?instrumentingAgentsForPage@InspectorInstrumentation@WebCore@@CAPAVInstrumentingAgents@2@PAVPage@2@@Z
+        ?isCSSExclusionsEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
         ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z
         ?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@UStringHash@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z
         ?lastChangeWasUserEdit@HTMLTextFormControlElement@WebCore@@QBE_NXZ

Modified: trunk/Source/WebKit2/win/WebKit2CFLite.def (114019 => 114020)


--- trunk/Source/WebKit2/win/WebKit2CFLite.def	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/WebKit2/win/WebKit2CFLite.def	2012-04-12 19:54:21 UTC (rev 114020)
@@ -170,6 +170,7 @@
         ?getLocationAndLengthFromRange@TextIterator@WebCore@@SA_NPAVElement@2@PBVRange@2@AAI2@Z
         ?hasShadowRoot@Element@WebCore@@QBE_NXZ
         ?instrumentingAgentsForPage@InspectorInstrumentation@WebCore@@CAPAVInstrumentingAgents@2@PAVPage@2@@Z
+        ?isCSSExclusionsEnabled@RuntimeEnabledFeatures@WebCore@@0_NA
         ?isPreloaded@CachedResourceLoader@WebCore@@QBE_NABVString@WTF@@@Z
         ?jsStringSlowCase@WebCore@@YA?AVJSValue@JSC@@PAVExecState@3@AAV?$HashMap@PAVStringImpl@WTF@@V?$Weak@VJSString@JSC@@@JSC@@UStringHash@2@U?$HashTraits@PAVStringImpl@WTF@@@2@U?$HashTraits@V?$Weak@VJSString@JSC@@@JSC@@@2@@WTF@@PAVStringImpl@6@@Z
         ?lastChangeWasUserEdit@HTMLTextFormControlElement@WebCore@@QBE_NXZ

Modified: trunk/Source/autotools/symbols.filter (114019 => 114020)


--- trunk/Source/autotools/symbols.filter	2012-04-12 19:50:46 UTC (rev 114019)
+++ trunk/Source/autotools/symbols.filter	2012-04-12 19:54:21 UTC (rev 114020)
@@ -129,6 +129,7 @@
 _ZN7WebCore22RuntimeEnabledFeatures31isMultipleShadowSubtreesEnabledE;
 _ZN7WebCore22RuntimeEnabledFeatures32setMultipleShadowSubtreesEnabledEb;
 _ZN7WebCore22RuntimeEnabledFeatures18isShadowDOMEnabledE;
+_ZN7WebCore22RuntimeEnabledFeatures22isCSSExclusionsEnabledE;
 _ZNK7WebCore8Document13nodesFromRectEiijjjjbb;
 _ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS_8NodeListE;
 _ZNK7WebCore6Editor26selectionStartHasMarkerForENS_14DocumentMarker10MarkerTypeEii;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to