Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 1ad1e7a08f871ab0411e2908c31b465e9925dfee
https://github.com/WebKit/WebKit/commit/1ad1e7a08f871ab0411e2908c31b465e9925dfee
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-01-22 (Thu, 22 Jan 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[WKCI] EWS for WK2 tests for GTK And WPE ports should give failure when there
is an infrastructure issue
https://bugs.webkit.org/show_bug.cgi?id=306025
Reviewed by Aakash Jain.
When the EWS for WK2 tests for GTK And WPE ports is unable to determine if a
patch introduces new failures
(for example because a patch is breaking the test runner) then the logic is
marking the build ended with
WARNINGS status, and that causes that the icon that is show at the GH PR to be
green (like if it passed)
which is totally confusing.
This patch modifies the step to report a FAILURE status instead.
This has been observed on https://github.com/WebKit/WebKit/pull/56871
* Tools/CISupport/ews-build/steps.py:
(AnalyzeLayoutTestsResultsRedTree.report_success):
(AnalyzeLayoutTestsResultsRedTree.report_infrastructure_issue_and_maybe_retry_build):
(AnalyzeLayoutTestsResultsRedTree.report_warning): Deleted.
* Tools/CISupport/ews-build/steps_unittest.py:
(TestAnalyzeLayoutTestsResultsRedTree.test_first_step_gives_unexpected_failure_and_clean_tree_unexpected_failure_last_try):
(TestAnalyzeLayoutTestsResultsRedTree.test_retry_finish):
Canonical link: https://commits.webkit.org/306012@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
