Title: [114029] branches/subpixellayout/Source/WebCore/accessibility

Diff

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityMenuListOption.h (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityMenuListOption.h	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityMenuListOption.h	2012-04-12 20:42:52 UTC (rev 114029)
@@ -46,7 +46,6 @@
 
     virtual AccessibilityRole roleValue() const { return MenuListOptionRole; }
     virtual bool canHaveChildren() const { return false; }
-    virtual LayoutSize size() const { return elementRect().size(); }
 
     virtual Element* actionElement() const;
     virtual bool isEnabled() const;

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityMenuListPopup.h (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityMenuListPopup.h	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityMenuListPopup.h	2012-04-12 20:42:52 UTC (rev 114029)
@@ -50,7 +50,6 @@
     virtual bool isMenuListPopup() const { return true; }
 
     virtual LayoutRect elementRect() const { return LayoutRect(); }
-    virtual LayoutSize size() const { return LayoutSize(); }
     virtual AccessibilityRole roleValue() const { return MenuListPopupRole; }
 
     virtual bool isVisible() const;

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityObject.h	2012-04-12 20:42:52 UTC (rev 114029)
@@ -506,7 +506,8 @@
     virtual LayoutRect boundingBoxRect() const { return LayoutRect(); }
     IntRect pixelSnappedBoundingBoxRect() const { return pixelSnappedIntRect(boundingBoxRect()); }
     virtual LayoutRect elementRect() const = 0;
-    virtual LayoutSize size() const { return elementRect().size(); }
+    LayoutSize size() const { return elementRect().size(); }
+    IntSize pixelSnappedSize() const { return elementRect().pixelSnappedSize(); }
     virtual IntPoint clickPoint();
     static IntRect boundingBoxForQuads(RenderObject*, const Vector<FloatQuad>&);
     

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2012-04-12 20:42:52 UTC (rev 114029)
@@ -1523,12 +1523,6 @@
     return boundingBoxRect();
 }
 
-LayoutSize AccessibilityRenderObject::size() const
-{
-    LayoutRect rect = elementRect();
-    return rect.size();
-}
-
 IntPoint AccessibilityRenderObject::clickPoint()
 {
     // Headings are usually much wider than their textual content. If the mid point is used, often it can be wrong.

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.h (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.h	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityRenderObject.h	2012-04-12 20:42:52 UTC (rev 114029)
@@ -166,7 +166,6 @@
     
     virtual LayoutRect boundingBoxRect() const;
     virtual LayoutRect elementRect() const;
-    virtual LayoutSize size() const;
     virtual IntPoint clickPoint();
     
     void setRenderer(RenderObject* renderer) { m_renderer = renderer; }

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.cpp (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.cpp	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.cpp	2012-04-12 20:42:52 UTC (rev 114029)
@@ -178,11 +178,6 @@
     return sliderThumbElementOf(sliderRenderer->node())->getRect();
 }
 
-LayoutSize AccessibilitySliderThumb::size() const
-{
-    return elementRect().size();
-}
-
 bool AccessibilitySliderThumb::accessibilityIsIgnored() const
 {
     AccessibilityObjectInclusion decision = accessibilityPlatformIncludesObject();

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.h (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.h	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilitySlider.h	2012-04-12 20:42:52 UTC (rev 114029)
@@ -75,7 +75,6 @@
 
     virtual AccessibilityRole roleValue() const { return SliderThumbRole; }
 
-    virtual LayoutSize size() const;
     virtual LayoutRect elementRect() const;
 
     virtual bool accessibilityIsIgnored() const;

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableColumn.cpp (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableColumn.cpp	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableColumn.cpp	2012-04-12 20:42:52 UTC (rev 114029)
@@ -67,11 +67,6 @@
     // this will be filled in when addChildren is called
     return m_columnRect;
 }
-
-LayoutSize AccessibilityTableColumn::size() const
-{
-    return elementRect().size();
-}
  
 AccessibilityObject* AccessibilityTableColumn::headerObject()
 {

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableColumn.h (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableColumn.h	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableColumn.h	2012-04-12 20:42:52 UTC (rev 114029)
@@ -57,7 +57,6 @@
     virtual void addChildren();
     virtual void setParent(AccessibilityObject*);
     
-    virtual LayoutSize size() const;
     virtual LayoutRect elementRect() const;
     
 private:    

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp	2012-04-12 20:42:52 UTC (rev 114029)
@@ -55,11 +55,6 @@
     return m_headerRect;
 }
 
-LayoutSize AccessibilityTableHeaderContainer::size() const
-{
-    return elementRect().size();
-}
-
 bool AccessibilityTableHeaderContainer::accessibilityIsIgnored() const
 {
     if (!m_parent)

Modified: branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.h (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.h	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.h	2012-04-12 20:42:52 UTC (rev 114029)
@@ -47,7 +47,6 @@
     
     virtual void addChildren();
     
-    virtual LayoutSize size() const;
     virtual LayoutRect elementRect() const;
     
 private:

Modified: branches/subpixellayout/Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceImage.cpp (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceImage.cpp	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/gtk/WebKitAccessibleInterfaceImage.cpp	2012-04-12 20:42:52 UTC (rev 114029)
@@ -48,7 +48,7 @@
 
 static void webkitAccessibleImageGetImagePosition(AtkImage* image, gint* x, gint* y, AtkCoordType coordType)
 {
-    IntRect rect = core(image)->elementRect();
+    IntRect rect = pixelSnappedIntRect(core(image)->elementRect());
     contentsRelativeToAtkCoordinateType(core(image), coordType, rect, x, y);
 }
 
@@ -59,7 +59,7 @@
 
 static void webkitAccessibleImageGetImageSize(AtkImage* image, gint* width, gint* height)
 {
-    IntSize size = core(image)->size();
+    IntSize size = core(image)->pixelSnappedSize();
 
     if (width)
         *width = size.width();

Modified: branches/subpixellayout/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm (114028 => 114029)


--- branches/subpixellayout/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm	2012-04-12 20:35:18 UTC (rev 114028)
+++ branches/subpixellayout/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapper.mm	2012-04-12 20:42:52 UTC (rev 114029)
@@ -1409,7 +1409,7 @@
 
 - (NSValue *)position
 {
-    IntRect rect = enclosingIntRect(m_object->elementRect());
+    IntRect rect = pixelSnappedIntRect(m_object->elementRect());
     NSPoint point;
     
     FrameView* frameView = m_object->documentFrameView();
@@ -2025,7 +2025,7 @@
         return [NSNumber numberWithBool: m_object->isEnabled()];
 
     if ([attributeName isEqualToString: NSAccessibilitySizeAttribute]) {
-        LayoutSize s = m_object->size();
+        IntSize s = m_object->pixelSnappedSize();
         return [NSValue valueWithSize: NSMakeSize(s.width(), s.height())];
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to