Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 65477f1a043ff67f1eedc402be84c49741ded2a6
https://github.com/WebKit/WebKit/commit/65477f1a043ff67f1eedc402be84c49741ded2a6
Author: Carlos Alberto Lopez Perez <[email protected]>
Date: 2026-01-23 (Fri, 23 Jan 2026)
Changed paths:
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[WKCI][GLIB] WK2 EWS logic doesn't take into account that there might not be
failures in the step layout-tests-repeat-failures (with patch)
https://bugs.webkit.org/show_bug.cgi?id=306102
Reviewed by Aakash Jain.
If on the first run with patch there are unexpected failures then a second step
to retry those failures multiple times with the patch is trigerred, and if in
that second step those retried failures end passing then the EWS should mark
the patch as passing because it introduces no new failures.
However the current EWS logic had a bug because in that case there won't be
info about the retries without patch (because those aren't needed, it can
already conclude that the patch is good without testing without patch).
This patch fixes the logic to only trigger the infrastructure exception when
the step to retry with patch (layout-tests-repeat-failures) didn't have a
retcode of SUCCESS or WARNINGS.
It also fixes a bug determining the number of flakies information to send
by e-mail. The tests that failed on the first run but not on the retry
step should be considered as flakies as well.
* Tools/CISupport/ews-build/steps.py:
(AnalyzeLayoutTestsResultsRedTree.run):
* Tools/CISupport/ews-build/steps_unittest.py:
(TestAnalyzeLayoutTestsResultsRedTree.test_pre_existent_failures):
(TestAnalyzeLayoutTestsResultsRedTree.test_step_retry_with_change_pass):
(TestAnalyzeLayoutTestsResultsRedTree):
(TestAnalyzeLayoutTestsResultsRedTree.test_step_retry_with_change_warnings):
Canonical link: https://commits.webkit.org/306085@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
