Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 6a1eadfc3e3e354664f95761f341766f8a75a312
https://github.com/WebKit/WebKit/commit/6a1eadfc3e3e354664f95761f341766f8a75a312
Author: Lauro Moura <[email protected]>
Date: 2026-01-23 (Fri, 23 Jan 2026)
Changed paths:
M Tools/Scripts/webkitpy/port/gtk.py
M Tools/Scripts/webkitpy/port/gtk_unittest.py
M Tools/Scripts/webkitpy/port/wpe.py
M Tools/Scripts/webkitpy/port/wpe_unittest.py
Log Message:
-----------
[GTK][resultsdb] Remove version_name from the uploaded results
https://bugs.webkit.org/show_bug.cgi?id=214511
Reviewed by Carlos Alberto Lopez Perez.
305707@main changed WPE and GTK to use the project version as the result
upload version instead of the kernel version, resulting in more stable
versioning.
Meanwhile, GTK still uses the display server name as the version_name.
This causes the frontend code to group different configurations with
different versions together in a single timeline, also dropping the
platform name and version, as it's implied from the version_name. Thus
for GTK we had rows with the cryptic title `Xvfb wk2 Debug...`.
On top of that, we have bugs like bug306091, where markers are not
rendered when configurations are grouped out of order. As the default
GTK timelines were grouped by version_name, it was more prone to be
affected by this problem than WPE.
This commit ensures we send an empty version_name field for both WPE and
GTK, aligning their behavior.
In fact, if we need the display server name in the future, we can add it
back as a different flavor.
Note that with the current resultsdbpy frontend code, this will create a
new result series for GTK on front page (i.e. decoupled from the
'Xvfb' group). But over time, the old configurations will be archived
out of the front page. And for long term history of GTK/WPE, we can use
tools like webkit-testhunter.
* Tools/Scripts/webkitpy/port/gtk.py:
(GtkPort.configuration_for_upload):
* Tools/Scripts/webkitpy/port/gtk_unittest.py:
(GtkPortTest.test_default_upload_configuration):
* Tools/Scripts/webkitpy/port/wpe.py:
(WPEPort.configuration_for_upload):
* Tools/Scripts/webkitpy/port/wpe_unittest.py:
(WPEPortTest.test_default_upload_configuration):
Canonical link: https://commits.webkit.org/306101@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
