Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 08bfd44f4d99ab4111fb0588c54d0a4a7b40ba37
https://github.com/WebKit/WebKit/commit/08bfd44f4d99ab4111fb0588c54d0a4a7b40ba37
Author: Alex Christensen <[email protected]>
Date: 2026-01-23 (Fri, 23 Jan 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm
Log Message:
-----------
NEW TEST:(305922@main) [macOS iOS] TestWebKitAPI.FocusWebView.MultipleFrames
is timing out
https://bugs.webkit.org/show_bug.cgi?id=306048
rdar://168688750
Unreviewed.
The test was waiting for navigation to complete then waiting for an alert that
sometimes was received
by the UI process in the same call to TestWebKitAPI::Util::run, and when that
happened the waiting for
the alert never completed because the alert was received before the call to
waitForAlert.
This fixes that issue, making the test no longer time out, and it does so by
waiting for navigation
to complete, then calling evaluateJavaScript to initiate the focus change which
causes the alert.
I also clean up the test a bit and make it more clear what needs to be fixed.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm:
(TestWebKitAPI::MultipleFrames)):
(TestWebKitAPI::DISABLED_MultipleFrames)): Deleted.
Canonical link: https://commits.webkit.org/306117@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
