Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b89408b1091f63f3832b2086510a675a04d5f404
https://github.com/WebKit/WebKit/commit/b89408b1091f63f3832b2086510a675a04d5f404
Author: Mike Gorse <[email protected]>
Date: 2026-01-23 (Fri, 23 Jan 2026)
Changed paths:
M Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp
M Source/WebKit/UIProcess/gtk/Display.cpp
M Source/WebKit/UIProcess/gtk/Display.h
M Source/WebKit/UIProcess/gtk/DisplayX11.cpp
Log Message:
-----------
AX: Remove accessibilityBusAddress from GTK display
https://bugs.webkit.org/show_bug.cgi?id=306148
Reviewed by Michael Catanzaro.
We have code to check AT_SPI_BUS_ADDRESS from the environment or query
at-spi-bus-launcher via DBus. This should suffice for finding the
accessibility bus. Historically, the address has also been stored as an
atom on the X display in order to allow applications running as the
super-user to be able to connect with accessibility clients running as a
normal user, but this is not common nowadays, and a WebKit application
running as root is going to crash anyhow when trying to execute bubblewrap.
We are sometimes obtaining an accessibility bus address that we don't have
permission to connect to, causing the process to abort later (see
https://gitlab.gnome.org/GNOME/at-spi2-core/core/-/issues/180), and this
change may help and should not do any harm.
* Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::accessibilityBusAddress const):
* Source/WebKit/UIProcess/gtk/Display.cpp:
(WebKit::Display::accessibilityBusAddress const): Deleted.
* Source/WebKit/UIProcess/gtk/Display.h:
* Source/WebKit/UIProcess/gtk/DisplayX11.cpp:
(WebKit::Display::accessibilityBusAddressX11 const): Deleted.
Canonical link: https://commits.webkit.org/306124@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
