Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 392961a9c317868619f939322ee736b7e7f11b58
https://github.com/WebKit/WebKit/commit/392961a9c317868619f939322ee736b7e7f11b58
Author: Richard Robinson <[email protected]>
Date: 2026-01-23 (Fri, 23 Jan 2026)
Changed paths:
M Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h
M Source/WebCore/PAL/pal/spi/cocoa/WritingToolsSPI.h
M Source/WebCore/PAL/pal/spi/ios/BrowserEngineKitSPI.h
M Source/WebCore/WebCore_Private.modulemap
M Source/WebKit/Configurations/WebKit.xcconfig
M Source/WebKit/Modules/Internal/module.modulemap
M Source/WebKit/Platform/spi/ios/UIKitSPI.h
M Source/WebKit/Shared/FrameInfoData.h
M Source/WebKit/Shared/FrameTreeNodeData.h
M Source/WebKit/Shared/JSHandleInfo.h
M Source/WebKit/Shared/WebFrameMetrics.h
M Source/WebKit/Shared/WebPushMessage.h
M Source/WebKit/Shared/WebsiteData/WebsiteData.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationInternal.h
M Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.h
M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
M Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm
M Source/WebKit/UIProcess/Cocoa/WKShareSheet.h
M Source/WebKit/UIProcess/ios/WKBaseScrollView.h
M Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
M Source/WebKit/UIProcess/mac/WebViewImpl.h
Log Message:
-----------
[Swift in WebKit] Remove a few module compilation guards from a few more
places
https://bugs.webkit.org/show_bug.cgi?id=305749
rdar://168425339
Reviewed by Aditya Keerthi.
Now that WebKit is modularized, remove some module guards from
WKWebViewInternal and
WKWebViewConfigurationInternal that are no longer needed.
Consequently, also add header audits to the relevant files and add nullability
annotations.
* Source/WebCore/PAL/pal/spi/cocoa/VisionKitCoreSPI.h:
* Source/WebCore/PAL/pal/spi/cocoa/WritingToolsSPI.h:
* Source/WebCore/PAL/pal/spi/ios/BrowserEngineKitSPI.h:
* Source/WebKit/Platform/spi/ios/UIKitSPI.h:
- Fix some SPI declarations
- Remove some module compilation guards
* Source/WebCore/WebCore_Private.modulemap:
Due to a Swift compiler bug involving incorrect instantiations of copy
constructors,
the sub-modules in the WebCore module map need to be implicit instead of
explicit so that
unrelated sub-modules are not required to be imported.
* Source/WebKit/Modules/Internal/module.modulemap:
The GeneratedSerializers.h file in WebKit is not modules-compliant, since it
relies on outside
context for header inclusion. Since adding these header includes to the file is
frowned upon,
instead add necessary sub-modules for the affected types to the webkit internal
module.
* Source/WebKit/Shared/FrameInfoData.h:
* Source/WebKit/Shared/FrameTreeNodeData.h:
* Source/WebKit/Shared/JSHandleInfo.h:
* Source/WebKit/Shared/WebFrameMetrics.h:
* Source/WebKit/Shared/WebPushMessage.h:
* Source/WebKit/Shared/WebsiteData/WebsiteData.h:
Add guards to prevent these files from being processed by modules on
configurations that don't support Cxx interop
Canonical link: https://commits.webkit.org/306126@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
