Title: [114035] trunk/Source/WebCore
- Revision
- 114035
- Author
- [email protected]
- Date
- 2012-04-12 14:14:07 -0700 (Thu, 12 Apr 2012)
Log Message
[BlackBerry] Web Inspector cookie expiry is showing the wrong date.
https://bugs.webkit.org/show_bug.cgi?id=83814
Patch by Konrad Piascik <[email protected]> on 2012-04-12
Reviewed by Rob Buis.
The internal representation for expiry is seconds, we need to convert it
to milliseconds by multiplying by 1000.
The value from this method doesn't get used anywhere except Web Inspector.
Manually tested with Web Inspector by examining the CookieItemView in the Resources Panel.
* platform/blackberry/ParsedCookie.cpp:
(WebCore::ParsedCookie::appendWebCoreCookie):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (114034 => 114035)
--- trunk/Source/WebCore/ChangeLog 2012-04-12 21:11:37 UTC (rev 114034)
+++ trunk/Source/WebCore/ChangeLog 2012-04-12 21:14:07 UTC (rev 114035)
@@ -1,3 +1,19 @@
+2012-04-12 Konrad Piascik <[email protected]>
+
+ [BlackBerry] Web Inspector cookie expiry is showing the wrong date.
+ https://bugs.webkit.org/show_bug.cgi?id=83814
+
+ Reviewed by Rob Buis.
+
+ The internal representation for expiry is seconds, we need to convert it
+ to milliseconds by multiplying by 1000.
+
+ The value from this method doesn't get used anywhere except Web Inspector.
+ Manually tested with Web Inspector by examining the CookieItemView in the Resources Panel.
+
+ * platform/blackberry/ParsedCookie.cpp:
+ (WebCore::ParsedCookie::appendWebCoreCookie):
+
2012-04-12 Adam Klein <[email protected]>
Always set V8 wrappers via V8DOMWrapper::setJSWrapperFor* instead of WeakReferenceMap::set()
Modified: trunk/Source/WebCore/platform/blackberry/ParsedCookie.cpp (114034 => 114035)
--- trunk/Source/WebCore/platform/blackberry/ParsedCookie.cpp 2012-04-12 21:11:37 UTC (rev 114034)
+++ trunk/Source/WebCore/platform/blackberry/ParsedCookie.cpp 2012-04-12 21:14:07 UTC (rev 114035)
@@ -181,6 +181,8 @@
void ParsedCookie::appendWebCoreCookie(Vector<Cookie>& cookieVector) const
{
cookieVector.append(Cookie(String(m_name), String(m_value), String(m_domain),
- String(m_path), m_expiry, m_isHttpOnly, m_isSecure, m_isSession));
+ // We multiply m_expiry by 1000 to convert from seconds to milliseconds.
+ // This value is passed to Web Inspector and used in the _javascript_ Date constructor.
+ String(m_path), (m_expiry * 1000), m_isHttpOnly, m_isSecure, m_isSession));
}
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
