Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c4ee30d3b1b98692df765d43c8b07dd3f1674de2
https://github.com/WebKit/WebKit/commit/c4ee30d3b1b98692df765d43c8b07dd3f1674de2
Author: Luke Warlow <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M
LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https_exclude=(Document_Window_HTML._)-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/details-toggle-source-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-toggle-source-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-toggle-source-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/source-attribute-retargeting.tentative-expected.txt
M
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.https_exclude=(Document_Window_HTML._)-expected.txt
M Source/WebCore/dom/CommandEvent.cpp
M Source/WebCore/dom/ToggleEvent.cpp
M Source/WebCore/dom/ToggleEvent.h
M Source/WebCore/dom/ToggleEvent.idl
M Source/WebCore/dom/ToggleEventTask.cpp
M Source/WebCore/dom/ToggleEventTask.h
M Source/WebCore/html/HTMLDetailsElement.cpp
M Source/WebCore/html/HTMLDialogElement.cpp
M Source/WebCore/html/HTMLDialogElement.h
M Source/WebCore/html/HTMLElement.cpp
M Source/WebCore/html/HTMLElement.h
M Source/WebCore/html/HTMLFormControlElement.cpp
Log Message:
-----------
Implement ToggleEvent.source
https://bugs.webkit.org/show_bug.cgi?id=293686
Reviewed by Tim Nguyen and Anne van Kesteren.
This implements the new source attribute on ToggleEvent, and wires it up from
command invokers for dialogs,
and all invokers for popover.
This also tweaks the source property getter on CommandEvent.
*
LayoutTests/imported/w3c/web-platform-tests/html/dom/idlharness.https_exclude=(Document_Window_HTML._)-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/details-toggle-source-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-toggle-source-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-toggle-source-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/the-button-element/command-and-commandfor/source-attribute-retargeting.tentative-expected.txt:
*
LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/dom/idlharness.https_exclude=(Document_Window_HTML._)-expected.txt:
* Source/WebCore/dom/CommandEvent.cpp:
(WebCore::CommandEvent::source const):
* Source/WebCore/dom/ToggleEvent.cpp:
(WebCore::ToggleEvent::ToggleEvent):
(WebCore::ToggleEvent::source const):
* Source/WebCore/dom/ToggleEvent.h:
* Source/WebCore/dom/ToggleEvent.idl:
* Source/WebCore/dom/ToggleEventTask.cpp:
(WebCore::ToggleEventTask::queue):
* Source/WebCore/dom/ToggleEventTask.h:
* Source/WebCore/html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::queueDetailsToggleEventTask):
* Source/WebCore/html/HTMLDialogElement.cpp:
(WebCore::HTMLDialogElement::show):
(WebCore::HTMLDialogElement::showModal):
(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::requestClose):
(WebCore::HTMLDialogElement::handleCommandInternal):
(WebCore::HTMLDialogElement::queueDialogToggleEventTask):
* Source/WebCore/html/HTMLDialogElement.h:
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::queuePopoverToggleEventTask):
(WebCore::HTMLElement::showPopoverInternal):
(WebCore::HTMLElement::hidePopoverInternal):
(WebCore::HTMLElement::togglePopover):
(WebCore::HTMLElement::handleCommandInternal):
* Source/WebCore/html/HTMLElement.h:
* Source/WebCore/html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::handlePopoverTargetAction):
Canonical link: https://commits.webkit.org/306152@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
