Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 79584197ef17af66bf9f300973111044b43c2d1d
https://github.com/WebKit/WebKit/commit/79584197ef17af66bf9f300973111044b43c2d1d
Author: Tyler Wilcock <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/accessibility/AXObjectCache.h
A Source/WebCore/accessibility/AXTextStateChangeIntent.cpp
M Source/WebCore/accessibility/AXTextStateChangeIntent.h
M Source/WebCore/accessibility/AccessibilityRenderObject.cpp
M Source/WebCore/accessibility/atspi/AXObjectCacheAtspi.cpp
M Source/WebCore/accessibility/mac/AXObjectCacheMac.mm
M Source/WebCore/dom/Element.h
M Source/WebCore/editing/CompositeEditCommand.cpp
M Source/WebCore/editing/DictationCommand.cpp
M Source/WebCore/editing/Editor.cpp
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/editing/TypingCommand.cpp
M Source/WebCore/page/EventHandler.cpp
M Source/WebCore/page/FocusController.cpp
Log Message:
-----------
AX: Refactor the text editing enums in AXTextStateChangeIntent.h to be enum
classes and add debugDescription methods
https://bugs.webkit.org/show_bug.cgi?id=306144
rdar://168783304
Reviewed by Ryosuke Niwa.
enum classes are more safe than plain enums because they don't accept implicit
conversions. Also add some debugDescription()
implementations for easier debugging.
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AccessibilityReplacedText::postTextStateChangeNotification):
(WebCore::AXObjectCache::postTextStateChangeNotification):
(WebCore::AXObjectCache::postTextReplacementNotification):
(WebCore::AXObjectCache::postTextReplacementNotificationForTextControl):
(WebCore::AXObjectCache::passwordNotificationTimerFired):
(WebCore::AXObjectCache::textChangeForEditType):
(WebCore::AXObjectCache::showIntent): Deleted.
* Source/WebCore/accessibility/AXObjectCache.h:
* Source/WebCore/accessibility/AXTextStateChangeIntent.cpp: Added.
(WebCore::debugDescription):
(WebCore::AXTextSelection::debugDescription const):
(WebCore::AXTextStateChangeIntent::debugDescription const):
* Source/WebCore/accessibility/AXTextStateChangeIntent.h:
(WebCore::AXTextStateChangeIntent::AXTextStateChangeIntent):
* Source/WebCore/accessibility/AccessibilityRenderObject.cpp:
(WebCore::setTextSelectionIntent):
(WebCore::AccessibilityRenderObject::setSelectedTextRange):
(WebCore::AccessibilityRenderObject::setSelectedVisiblePositionRange const):
* Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:
(platformChangeTypeForWebCoreChangeType):
(platformEditTypeForWebCoreEditType):
(platformDirectionForWebCoreDirection):
(platformGranularityForWebCoreGranularity):
(WebCore::AXObjectCache::inferDirectionFromIntent):
(WebCore::AXObjectCache::postTextSelectionChangePlatformNotification):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
(WebCore::AXObjectCache::postUserInfoForChanges):
(WebCore::AXObjectCache::postTextReplacementPlatformNotificationForTextControl):
* Source/WebCore/dom/Element.h:
(WebCore::Element::defaultFocusTextStateChangeIntent):
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::postTextStateChangeNotification):
* Source/WebCore/editing/DictationCommand.cpp:
(WebCore::DictationCommand::doApply):
* Source/WebCore/editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
(WebCore::Editor::postTextStateChangeNotificationForCut):
* Source/WebCore/editing/FrameSelection.cpp:
(WebCore::FrameSelection::moveWithoutValidationTo):
(WebCore::FrameSelection::setSelectionByMouseIfDifferent):
(WebCore::FrameSelection::textSelectionIntent):
(WebCore::textSelectionWithDirectionAndGranularity):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::selectAll):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::postTextStateChangeNotificationForDeletion):
(WebCore::TypingCommand::insertTextAndNotifyAccessibility):
(WebCore::TypingCommand::insertLineBreakAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorAndNotifyAccessibility):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContentAndNotifyAccessibility):
* Source/WebCore/page/EventHandler.cpp:
(WebCore::setInitialKeyboardSelection):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::findAndFocusElementInDocumentOrderStartingWithFrame):
Canonical link: https://commits.webkit.org/306160@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
