Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 25a293b2f567944d2260ba574045ce676da8603c
https://github.com/WebKit/WebKit/commit/25a293b2f567944d2260ba574045ce676da8603c
Author: Megan Gardner <[email protected]>
Date: 2026-01-25 (Sun, 25 Jan 2026)
Changed paths:
M Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm
Log Message:
-----------
Cross-platform view should not have "NS" in the title.
https://bugs.webkit.org/show_bug.cgi?id=306163
rdar://168803553
Reviewed by Abrar Rahman Protyasha.
The name of this variable is confusing because it is a
cross-platform type, that is either an NSView or a UIView,
therefor it should not have NS in the name. It confused me
when I was working on this test.
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm:
(TestWebKitAPI::AdvanceFocusRelinquishToChrome)):
(-[TestNSTextView keyDown:]): Deleted.
(-[TestNSTextView acceptsFirstResponder]): Deleted.
(-[TestNSTextView canBecomeKeyView]): Deleted.
(-[TestNSTextView becomeFirstResponder]): Deleted.
(-[TestNSTextView resignFirstResponder]): Deleted.
Canonical link: https://commits.webkit.org/306173@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
