Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cee96ea04659ee7feac8252ec197f0fffc5336f5
https://github.com/WebKit/WebKit/commit/cee96ea04659ee7feac8252ec197f0fffc5336f5
Author: Jer Noble <[email protected]>
Date: 2026-01-26 (Mon, 26 Jan 2026)
Changed paths:
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.h
M Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm
M Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm
M Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm
Log Message:
-----------
WebAVPictureInPicturePlayerLayerView doesn't clean up view/layer hierarchy
rdar://168346213
https://bugs.webkit.org/show_bug.cgi?id=305996
Reviewed by David Kilzer.
When deallocating a UIView, the view will message its children
and their layers. If those children or their layers have been
deallocated, a dangling reference could be messaged. Ensure
WebAVPictureInPicturePlayerLayerView cleans up its children
before deallocating.
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.h:
* Source/WebCore/platform/cocoa/WebAVPlayerLayer.mm:
(-[WebAVPlayerLayer setVideoSublayer:]):
* Source/WebCore/platform/cocoa/WebAVPlayerLayerView.mm:
(WebCore::WebAVPictureInPicturePlayerLayerView_dealloc):
(WebCore::allocWebAVPictureInPicturePlayerLayerViewInstance):
* Source/WebCore/platform/ios/VideoPresentationInterfaceAVKitLegacy.mm:
(WebAVPictureInPictureContentViewController_dealloc):
Canonical link: https://commits.webkit.org/306231@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
