Title: [114052] trunk/Source/_javascript_Core
- Revision
- 114052
- Author
- [email protected]
- Date
- 2012-04-12 17:09:40 -0700 (Thu, 12 Apr 2012)
Log Message
StructureStubInfo::reset() causes leaks of PolymorphicAccessStructureList and ExecutableMemoryHandle objects
https://bugs.webkit.org/show_bug.cgi?id=83823
Reviewed by Gavin Barraclough.
Put the clearing of the accessType to after the call to deref() so that
deref() can use the accessType to delete referenced objects as needed.
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::reset):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (114051 => 114052)
--- trunk/Source/_javascript_Core/ChangeLog 2012-04-13 00:08:46 UTC (rev 114051)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-04-13 00:09:40 UTC (rev 114052)
@@ -1,3 +1,16 @@
+2012-04-12 Michael Saboff <[email protected]>
+
+ StructureStubInfo::reset() causes leaks of PolymorphicAccessStructureList and ExecutableMemoryHandle objects
+ https://bugs.webkit.org/show_bug.cgi?id=83823
+
+ Reviewed by Gavin Barraclough.
+
+ Put the clearing of the accessType to after the call to deref() so that
+ deref() can use the accessType to delete referenced objects as needed.
+
+ * bytecode/StructureStubInfo.h:
+ (JSC::StructureStubInfo::reset):
+
2012-04-12 Balazs Kelemen <[email protected]>
[Qt] Fix WebKit1 build with V8
Modified: trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h (114051 => 114052)
--- trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h 2012-04-13 00:08:46 UTC (rev 114051)
+++ trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h 2012-04-13 00:09:40 UTC (rev 114052)
@@ -163,8 +163,8 @@
void reset()
{
+ deref();
accessType = access_unset;
- deref();
stubRoutine = MacroAssemblerCodeRef();
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
