Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dee86de8f60887fec029d52c20611804482deb5c
https://github.com/WebKit/WebKit/commit/dee86de8f60887fec029d52c20611804482deb5c
Author: Anne van Kesteren <[email protected]>
Date: 2026-01-27 (Tue, 27 Jan 2026)
Changed paths:
M Source/JavaScriptCore/runtime/JSCJSValue.h
M Source/WTF/wtf/HashTraits.h
M Source/WebKit/NetworkProcess/Downloads/DownloadManager.cpp
M Source/WebKit/NetworkProcess/Downloads/DownloadManager.h
M Source/WebKit/NetworkProcess/Downloads/cocoa/DownloadCocoa.mm
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp
M Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.h
M Source/WebKit/NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h
M Source/WebKit/NetworkProcess/storage/FileSystemStorageManager.cpp
M Source/WebKit/NetworkProcess/storage/FileSystemStorageManager.h
M Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm
Log Message:
-----------
Convert HashMap<..., RefPtr to Ref in NetworkProcess, take 2
https://bugs.webkit.org/show_bug.cgi?id=305723
Reviewed by Darin Adler.
The changes in NetworkRTCUDPSocketCocoa caused a debug crash because
PairHashTraits::emptyValue() containing a std::pair move-constructs the
Ref. After some iteration Claude AI suggested this
constructEmptyValue() fix in PairHashTraits to avoid move-construction.
This PairHashTraits fix caused a problem for JSVALUE32_64 that we are
again addressing with a fix from Claude AI modulo some iteration.
Claude also identified that part of
EncodedJSValueWithRepresentationHashTraits is now redundant.
Also make m_client in DownloadManager const so we can remove
protectedClient().
Canonical link: https://commits.webkit.org/306278@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications