Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c9e8120c5f0a0dff53c44f13cdbd74861762acf3
      
https://github.com/WebKit/WebKit/commit/c9e8120c5f0a0dff53c44f13cdbd74861762acf3
  Author: Cole Carley <[email protected]>
  Date:   2026-01-27 (Tue, 27 Jan 2026)

  Changed paths:
    M 
Tools/TestWebKitAPI/Tests/WebKitCocoa/NoResumeSoundPlayedToTheEndAfterThePageBecomesVisible.mm
    M Tools/TestWebKitAPI/cocoa/TestWKWebView.h
    M Tools/TestWebKitAPI/cocoa/TestWKWebView.mm

  Log Message:
  -----------
  Fix WebKit.NoResumeSoundPlayedToTheEndAfterThePageBecomesVisible on iOS
https://bugs.webkit.org/show_bug.cgi?id=306063
rdar://168705920

Reviewed by Brent Fulgham.

The test was incorrectly hiding the window on iOS. It was waiting for the
'visibilitychange' event, but that is not fired on iOS when using the
setHidden function. Instead, we resign key window and wait for the activity
state update to complete.

* 
Tools/TestWebKitAPI/Tests/WebKitCocoa/NoResumeSoundPlayedToTheEndAfterThePageBecomesVisible.mm:
(TEST(WebKit, NoResumeSoundPlayedToTheEndAfterThePageBecomesVisible)):
* Tools/TestWebKitAPI/cocoa/TestWKWebView.h:
* Tools/TestWebKitAPI/cocoa/TestWKWebView.mm:
(-[TestWKWebView setVisibility:]):

Canonical link: https://commits.webkit.org/306313@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to