Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 05091ff70c574740e36fa7afe89f76375ade2cc6
https://github.com/WebKit/WebKit/commit/05091ff70c574740e36fa7afe89f76375ade2cc6
Author: Etienne Segonzac <[email protected]>
Date: 2026-01-28 (Wed, 28 Jan 2026)
Changed paths:
M
Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView+Analysis.swift
M
Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView+Generation.swift
M
Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView+Rendering.swift
M Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView+Surface.swift
M Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView.swift
M
Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageViewConstants.swift
Log Message:
-----------
Follow-up: address more comments after the 305290@main upstream
https://bugs.webkit.org/show_bug.cgi?id=305923
<rdar://167010240>
Reviewed by Richard Robinson.
Remove the `Task.detached` and `@unchecked Sendable` uses and
address style comments now that the upstream patch has landed.
Bump the compiler guard to 6.2 because of the `@concurrent` use.
* Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView+Analysis.swift:
(WKSeparatedImageView.pickViewMode):
(WKSeparatedImageView.analyze):
Break out the analysis in a `@concurrent` async function.
Keep a simple Task (not detached) for the cancellation support.
(scoreImage(_:)):
(WKSeparatedImageView.startImageAnalysis): Deleted.
Code clean-up.
* Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView+Generation.swift:
(WKSeparatedImageView.startImage3DGeneration):
(WKSeparatedImageView.generate):
Break out the generation in a `@concurrent` async function.
Keep a simple Task (not detached) for the cancellation support.
(makeVoidPromise() -> (promise: Task<Void:Never:fulfill:)):
(ContinuationBox.continuation): Deleted.
Use an AsyncStream instead of the `@unchecked Sendable` ContinuationBox.
(set(for:spatial3DImage:desiredViewingModeSpatial:)): Deleted.
(updateDesiredViewingMode(for:_:)): Deleted.
(get(for:)): Deleted.
(forget(_:)): Deleted.
* Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView+Rendering.swift:
(WKSeparatedImageView.updateContents):
(WKSeparatedImageView.updateUI):
* Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView.swift:
(WKSeparatedImageView.desiredViewingModeSpatial):
Add subscript support to the ImagePresentationCache.
* Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageView+Surface.swift:
(WKSeparatedImageView.didReceiveImage):
(WKSeparatedImageView.computeHash() async -> (Data:NSString:)):
Break out the hash computation in a `@concurrent` async function.
Keep a simple Task (not detached) for the cancellation support.
* Source/WebKit/UIProcess/Cocoa/Separated/WKSeparatedImageViewConstants.swift:
Canonical link: https://commits.webkit.org/306335@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
