Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8accbbaa5baa01387b788b82fc40501662397b02
https://github.com/WebKit/WebKit/commit/8accbbaa5baa01387b788b82fc40501662397b02
Author: Adrian Perez de Castro <[email protected]>
Date: 2026-01-28 (Wed, 28 Jan 2026)
Changed paths:
M Source/WebKit/UIProcess/API/glib/IconDatabase.cpp
Log Message:
-----------
[GTK] Improve IconDatabase logging
https://bugs.webkit.org/show_bug.cgi?id=306416
Reviewed by Carlos Garcia Campos.
Switch logging statements to use RELEASE_LOG_ERROR() instead of plain
LOG_ERROR(), which allows specifying the logging channel, and take
advantage of the existing IconDatabase channel.
Add the error code and last error message from the underlying database
to all logging statements, to aid debugging when needed. Some of them
already included those, but most did not, so this makes the logged
messages more consistent as well.
While at it, add a missing check and the corresponding logging statement
when creating the prepared statement used for checking the database
version fails.
* Source/WebKit/UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::IconDatabase):
(WebKit::IconDatabase::createTablesIfNeeded):
(WebKit::IconDatabase::populatePageURLToIconURLsMap):
(WebKit::IconDatabase::pruneTimerFired):
(WebKit::IconDatabase::iconIDForIconURL):
(WebKit::IconDatabase::setIconIDForPageURL):
(WebKit::IconDatabase::iconData):
(WebKit::IconDatabase::addIcon):
(WebKit::IconDatabase::updateIconTimestamp):
(WebKit::IconDatabase::deleteIcon):
Canonical link: https://commits.webkit.org/306358@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
