Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: f2ced711567e81c20bd668e5a0094d5e3a49ffe9
https://github.com/WebKit/WebKit/commit/f2ced711567e81c20bd668e5a0094d5e3a49ffe9
Author: Richard Robinson <[email protected]>
Date: 2026-01-28 (Wed, 28 Jan 2026)
Changed paths:
M Source/WebCore/Headers.cmake
M Source/WebCore/Sources.txt
M Source/WebCore/SourcesCocoa.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/editing/FrameSelection.cpp
M Source/WebCore/html/HTMLElement.cpp
M Source/WebCore/html/HTMLElement.h
A Source/WebCore/platform/SelectionGeometry.cpp
A Source/WebCore/platform/SelectionGeometry.h
R Source/WebCore/platform/ios/SelectionGeometry.cpp
R Source/WebCore/platform/ios/SelectionGeometry.h
M Source/WebCore/rendering/LogicalSelectionOffsetCachesInlines.h
M Source/WebCore/rendering/RenderBlock.cpp
M Source/WebCore/rendering/RenderImage.cpp
M Source/WebCore/rendering/RenderImage.h
M Source/WebCore/rendering/RenderLineBreak.cpp
M Source/WebCore/rendering/RenderLineBreak.h
M Source/WebCore/rendering/RenderObject.cpp
M Source/WebCore/rendering/RenderObject.h
M Source/WebCore/rendering/RenderText.cpp
M Source/WebCore/rendering/RenderText.h
M Source/WebKit/Shared/EditorState.cpp
M Source/WebKit/Shared/EditorState.h
M Source/WebKit/Shared/EditorState.serialization.in
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Log Message:
-----------
[AppKit Gestures] Expose the `EditorState.selectionGeometries` field on macOS
https://bugs.webkit.org/show_bug.cgi?id=306397
rdar://169060367
Reviewed by Wenson Hsieh, Tim Horton, and Abrar Rahman Protyasha.
Like on iOS, expose `EditorState.selectionGeometries` on macOS so it too can
provide
an abstracted text selection value like iOS does with UITextSelection.
This PR sets the property on the editor state, but has no observable effects on
its own.
It will be used in a subsequent PR.
* Source/WebCore/editing/FrameSelection.cpp:
* Source/WebCore/html/HTMLElement.cpp:
* Source/WebCore/html/HTMLElement.h:
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::collectSelectionGeometries):
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::collectSelectionGeometries):
* Source/WebCore/rendering/RenderLineBreak.h:
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::collectSelectionGeometries):
(WebCore::usesVisuallyContiguousBidiTextSelection):
(WebCore::makeBidiSelectionVisuallyContiguousIfNeeded):
* Source/WebCore/rendering/RenderObject.h:
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::collectSelectionGeometries):
* Source/WebCore/rendering/RenderText.h:
* Source/WebKit/Shared/EditorState.cpp:
(WebKit::operator<<):
(WebKit::EditorState::move):
* Source/WebKit/Shared/EditorState.h:
* Source/WebKit/Shared/EditorState.serialization.in:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::convertContentToRootView):
(WebKit::WebPage::getPlatformEditorStateCommon const):
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPlatformEditorState const):
Canonical link: https://commits.webkit.org/306369@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
