Title: [114064] trunk/LayoutTests
Revision
114064
Author
[email protected]
Date
2012-04-12 18:11:16 -0700 (Thu, 12 Apr 2012)

Log Message

Make layout tests not access apache on localhost:80
https://bugs.webkit.org/show_bug.cgi?id=82197

Patch by Pablo Flouret <[email protected]> on 2012-04-12
Reviewed by Ryosuke Niwa.

It pollutes the logs of people running a local webserver, and has the
potential for changing the results of tests run locally.

* fast/dom/onerror-img.html:
* fast/js/custom-constructors-expected.txt:
* fast/js/script-tests/custom-constructors.js:
* fast/notifications/notifications-double-show.html:
* fast/notifications/notifications-with-permission.html:
* fast/notifications/notifications-without-permission.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (114063 => 114064)


--- trunk/LayoutTests/ChangeLog	2012-04-13 01:08:21 UTC (rev 114063)
+++ trunk/LayoutTests/ChangeLog	2012-04-13 01:11:16 UTC (rev 114064)
@@ -1,3 +1,20 @@
+2012-04-12  Pablo Flouret  <[email protected]>
+
+        Make layout tests not access apache on localhost:80
+        https://bugs.webkit.org/show_bug.cgi?id=82197
+
+        Reviewed by Ryosuke Niwa.
+
+        It pollutes the logs of people running a local webserver, and has the
+        potential for changing the results of tests run locally.
+
+        * fast/dom/onerror-img.html:
+        * fast/js/custom-constructors-expected.txt:
+        * fast/js/script-tests/custom-constructors.js:
+        * fast/notifications/notifications-double-show.html:
+        * fast/notifications/notifications-with-permission.html:
+        * fast/notifications/notifications-without-permission.html:
+
 2012-04-12  Rob Buis  <[email protected]>
 
         XMLSerializer().serializeToString() doesn't generate the XML declaration markup like Opera and Firefox

Modified: trunk/LayoutTests/fast/dom/onerror-img.html (114063 => 114064)


--- trunk/LayoutTests/fast/dom/onerror-img.html	2012-04-13 01:08:21 UTC (rev 114063)
+++ trunk/LayoutTests/fast/dom/onerror-img.html	2012-04-13 01:11:16 UTC (rev 114064)
@@ -24,7 +24,7 @@
             layoutTestController.notifyDone();
         }
     };
-    img1.src = ""
+    img1.src = ""
 }
 </script>
 </head>

Modified: trunk/LayoutTests/fast/js/custom-constructors-expected.txt (114063 => 114064)


--- trunk/LayoutTests/fast/js/custom-constructors-expected.txt	2012-04-13 01:08:21 UTC (rev 114063)
+++ trunk/LayoutTests/fast/js/custom-constructors-expected.txt	2012-04-13 01:11:16 UTC (rev 114064)
@@ -40,8 +40,8 @@
 PASS new Audio().tagName is "AUDIO"
 PASS new Audio().src is ""
 PASS new Audio().preload is "auto"
-PASS new Audio('http://localhost/someurl').src is "http://localhost/someurl"
-PASS new Audio('http://localhost/someurl').preload is "auto"
+PASS new Audio('http://0.0.0.0/someurl').src is "http://0.0.0.0/someurl"
+PASS new Audio('http://0.0.0.0/someurl').preload is "auto"
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/fast/js/script-tests/custom-constructors.js (114063 => 114064)


--- trunk/LayoutTests/fast/js/script-tests/custom-constructors.js	2012-04-13 01:08:21 UTC (rev 114063)
+++ trunk/LayoutTests/fast/js/script-tests/custom-constructors.js	2012-04-13 01:11:16 UTC (rev 114064)
@@ -53,5 +53,5 @@
 
 shouldBeEqualToString("new Audio().src", "");
 shouldBeEqualToString("new Audio().preload", "auto");
-shouldBeEqualToString("new Audio('http://localhost/someurl').src", "http://localhost/someurl");
-shouldBeEqualToString("new Audio('http://localhost/someurl').preload", "auto");
+shouldBeEqualToString("new Audio('http://0.0.0.0/someurl').src", "http://0.0.0.0/someurl");
+shouldBeEqualToString("new Audio('http://0.0.0.0/someurl').preload", "auto");

Modified: trunk/LayoutTests/fast/notifications/notifications-double-show-expected.txt (114063 => 114064)


--- trunk/LayoutTests/fast/notifications/notifications-double-show-expected.txt	2012-04-13 01:08:21 UTC (rev 114063)
+++ trunk/LayoutTests/fast/notifications/notifications-double-show-expected.txt	2012-04-13 01:11:16 UTC (rev 114064)
@@ -1,4 +1,4 @@
-DESKTOP NOTIFICATION: icon http://localhost/my_icon.png, title New E-mail, text Meet me tonight at 8!
+DESKTOP NOTIFICATION: icon http://0.0.0.0/my_icon.png, title New E-mail, text Meet me tonight at 8!
 Sending notifications...
 
 

Modified: trunk/LayoutTests/fast/notifications/notifications-double-show.html (114063 => 114064)


--- trunk/LayoutTests/fast/notifications/notifications-double-show.html	2012-04-13 01:08:21 UTC (rev 114063)
+++ trunk/LayoutTests/fast/notifications/notifications-double-show.html	2012-04-13 01:11:16 UTC (rev 114064)
@@ -19,7 +19,7 @@
                 log("FAIL: No webkitNotifications interface!");
             }
             
-            var N = window.webkitNotifications.createNotification("http://localhost/my_icon.png", "New E-mail", "Meet me tonight at 8!");
+            var N = window.webkitNotifications.createNotification("http://0.0.0.0/my_icon.png", "New E-mail", "Meet me tonight at 8!");
             N._ondisplay_ = function() { layoutTestController.notifyDone(); }
             N.show();
             N.show();

Modified: trunk/LayoutTests/fast/notifications/notifications-with-permission-expected.txt (114063 => 114064)


--- trunk/LayoutTests/fast/notifications/notifications-with-permission-expected.txt	2012-04-13 01:08:21 UTC (rev 114063)
+++ trunk/LayoutTests/fast/notifications/notifications-with-permission-expected.txt	2012-04-13 01:11:16 UTC (rev 114064)
@@ -1,5 +1,5 @@
-DESKTOP NOTIFICATION: contents at http://localhost/my_notification.html
-DESKTOP NOTIFICATION: icon http://localhost/my_icon.png, title New E-mail, text Meet me tonight at 8!
+DESKTOP NOTIFICATION: contents at http://0.0.0.0/my_notification.html
+DESKTOP NOTIFICATION: icon http://0.0.0.0/my_icon.png, title New E-mail, text Meet me tonight at 8!
 Sending notifications with permission...
 
 

Modified: trunk/LayoutTests/fast/notifications/notifications-with-permission.html (114063 => 114064)


--- trunk/LayoutTests/fast/notifications/notifications-with-permission.html	2012-04-13 01:08:21 UTC (rev 114063)
+++ trunk/LayoutTests/fast/notifications/notifications-with-permission.html	2012-04-13 01:11:16 UTC (rev 114064)
@@ -19,10 +19,10 @@
                 log("FAIL: No webkitNotifications interface!");
             }
             
-            var N = window.webkitNotifications.createHTMLNotification("http://localhost/my_notification.html");
+            var N = window.webkitNotifications.createHTMLNotification("http://0.0.0.0/my_notification.html");
             N.show();
             
-            var M = window.webkitNotifications.createNotification("http://localhost/my_icon.png", "New E-mail", "Meet me tonight at 8!");
+            var M = window.webkitNotifications.createNotification("http://0.0.0.0/my_icon.png", "New E-mail", "Meet me tonight at 8!");
             M._ondisplay_ = function() { layoutTestController.notifyDone(); }
             M.show();
         }

Modified: trunk/LayoutTests/fast/notifications/notifications-without-permission.html (114063 => 114064)


--- trunk/LayoutTests/fast/notifications/notifications-without-permission.html	2012-04-13 01:08:21 UTC (rev 114063)
+++ trunk/LayoutTests/fast/notifications/notifications-without-permission.html	2012-04-13 01:11:16 UTC (rev 114064)
@@ -19,7 +19,7 @@
             }
             
             try {
-                var N = window.webkitNotifications.createNotification("http://localhost/my_icon.png", "New E-mail", "Meet me tonight at 8!");
+                var N = window.webkitNotifications.createNotification("http://0.0.0.0/my_icon.png", "New E-mail", "Meet me tonight at 8!");
                 N.show();
                 log("FAIL: Should have thrown security exception.");
             } catch (e) {
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to