Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b53de98410e34105e58be9eb87fab86736f37d75
https://github.com/WebKit/WebKit/commit/b53de98410e34105e58be9eb87fab86736f37d75
Author: Abrar Rahman Protyasha <[email protected]>
Date: 2026-01-29 (Thu, 29 Jan 2026)
Changed paths:
M Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm
Log Message:
-----------
[AppKit Gestures] Single click and double click interactions should be
handled separately
https://bugs.webkit.org/show_bug.cgi?id=306462
rdar://163660909
Reviewed by Tim Horton.
In 306218@main, we refactored our input handling to support
NSClickGestureRecognizer. It has proven valuable to be able to
distinguish between single/double click interactions through a pair of
unique click gesture recognizers. Bespoke recognizers for each
interaction type enables respecting only the subset of click
interactions we want to (or are prepared to) respond to.
In this patch, we add a separate NSClickGestureRecognizer that will
handle double click gestures. Initially, we want to hook this up with
smart magnification.
* Source/WebKit/UIProcess/mac/WKAppKitGestureController.mm:
(-[WKAppKitGestureController configureForSingleClick:]):
(-[WKAppKitGestureController configureForDoubleClick:]):
(-[WKAppKitGestureController initWithPage:viewImpl:]):
(-[WKAppKitGestureController setUpSingleClickGestureRecognizer]):
(-[WKAppKitGestureController setUpDoubleClickGestureRecognizer]):
(-[WKAppKitGestureController addGesturesToWebView]):
(-[WKAppKitGestureController enableGesturesIfNeeded]):
(-[WKAppKitGestureController singleClickGestureRecognized:]):
(-[WKAppKitGestureController doubleClickGestureRecognized:]):
(-[WKAppKitGestureController
gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKAppKitGestureController gestureRecognizerShouldBegin:]):
(-[WKAppKitGestureController configureForClicking:]): Deleted.
(-[WKAppKitGestureController setUpClickGestureRecognizer]): Deleted.
(-[WKAppKitGestureController clickGestureRecognized:]): Deleted.
Canonical link: https://commits.webkit.org/306404@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
