Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 7e6b3bf3ceffb8a635f8acb49d3f96b7c3b23a78
https://github.com/WebKit/WebKit/commit/7e6b3bf3ceffb8a635f8acb49d3f96b7c3b23a78
Author: Brandon Stewart <[email protected]>
Date: 2026-01-29 (Thu, 29 Jan 2026)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-lanes/tentative/subgrid/row/grid-lanes-subgrid-002a-expected.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-lanes/tentative/subgrid/row/grid-lanes-subgrid-002a-ref.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-lanes/tentative/subgrid/row/grid-lanes-subgrid-002a.html
Log Message:
-----------
[grid-lanes] Fix grid-lanes-subgrid-002a test to match cross-browser
rendering behavior
https://bugs.webkit.org/show_bug.cgi?id=306448
rdar://problem/169113705
Reviewed by Elika Etemad.
grid-lanes-subgrid-002a
-ref and -expected tests are implemented on a grid, which sets the height of
items.
So items 2 and 3 need to be 40 px as that is the height of the grid row 1.
Item 5 is a simple 30px too as that is just the height of the second row.
Now the subgrid requires special attention.
We first need to calculate the height of the subgrid, which is the row 2 + gap
+ row 3 heights.
Row 2 is a height of 30px, so 4a and 4b I would expect to add up to that.
Row 3 is similar a height of 20px, so we need to set 4c.
Now, we are losing a single pixel as these seem to be resolving to 29px for row
2 and 19px for row 3 heights.
* LayoutTests/TestExpectations:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-lanes/tentative/subgrid/row/grid-lanes-subgrid-002a-expected.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-lanes/tentative/subgrid/row/grid-lanes-subgrid-002a-ref.html:
*
LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-lanes/tentative/subgrid/row/grid-lanes-subgrid-002a.html:
Canonical link: https://commits.webkit.org/306411@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
