Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 9a9be848b4e3097378c910994948caeeb5c51ee8
https://github.com/WebKit/WebKit/commit/9a9be848b4e3097378c910994948caeeb5c51ee8
Author: Said Abou-Hallawa <[email protected]>
Date: 2026-01-29 (Thu, 29 Jan 2026)
Changed paths:
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-dynamic-expected.html
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-dynamic.html
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-initial-expected.html
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-initial.html
M
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/the-checkmark-pseudo-element.tentative-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-checkmark-expected.txt
M
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-base-appearance-computed-style-expected.txt
M LayoutTests/platform/gtk/TestExpectations
M Source/JavaScriptCore/inspector/protocol/CSS.json
M Source/WebCore/animation/WebAnimationUtilities.cpp
M Source/WebCore/css/CSSPseudoSelectors.json
M Source/WebCore/css/CSSSelector.cpp
M Source/WebCore/cssjit/SelectorCompiler.cpp
M Source/WebCore/html/HTMLInputElement.cpp
M Source/WebCore/inspector/agents/InspectorCSSAgent.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.cpp
M Source/WebCore/rendering/style/RenderStyleConstants.h
M Source/WebCore/rendering/updating/RenderTreeBuilder.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.h
M Source/WebCore/style/StyleTreeResolver.cpp
M Source/WebCore/style/computed/StyleComputedStyleBase.h
M Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js
Log Message:
-----------
[appearance: base] Reland the pseudo element ::checkmark
https://bugs.webkit.org/show_bug.cgi?id=305600
rdar://168599248
Reviewed by Tim Nguyen and Antti Koivisto.
Reland 304095@main and 304390@main after:
1. Fixing RenderStyle size by removing the double CheckedPtr counters
305612@main.
2. Freeing some bits in NonInheritedFlags 306352@main
So adding new ::checkmark pseudo element type should not increase RenderStyle
size.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-dynamic-expected.html:
Added.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-dynamic.html:
Added.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-initial-expected.html:
Added.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-initial.html:
Added.
*
LayoutTests/imported/w3c/web-platform-tests/css/css-pseudo/parsing/the-checkmark-pseudo-element.tentative-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/css/cssom/getComputedStyle-pseudo-checkmark-expected.txt:
*
LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/customizable-select/select-base-appearance-computed-style-expected.txt:
* LayoutTests/platform/gtk/TestExpectations:
* Source/JavaScriptCore/inspector/protocol/CSS.json:
* Source/WebCore/animation/WebAnimationUtilities.cpp:
(WebCore::compareStyleOriginatedAnimationOwningElementPositionsInDocumentTreeOrder):
(WebCore::pseudoElementIdentifierAsString):
* Source/WebCore/css/CSSPseudoSelectors.json:
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::stylePseudoElementTypeFor):
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::constructFragmentsInternal):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setChecked):
* Source/WebCore/inspector/agents/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::protocolValueForPseudoElementType):
* Source/WebCore/rendering/style/RenderStyleConstants.cpp:
(WebCore::operator<<):
* Source/WebCore/rendering/style/RenderStyleConstants.h:
* Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:
(WebCore::RenderTreeBuilder::updateAfterDescendants):
* Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp:
(WebCore::RenderTreeBuilder::FormControls::updateAfterDescendants):
(WebCore::RenderTreeBuilder::FormControls::updateCheckmark):
* Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.h:
* Source/WebCore/style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveElement):
* Source/WebCore/style/computed/StyleComputedStyleBase.h:
* Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js:
(WI.CSSManager.displayNameForPseudoId):
Canonical link: https://commits.webkit.org/306440@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
