Branch: refs/heads/webkitglib/2.52
Home: https://github.com/WebKit/WebKit
Commit: 3dcd6c9672936bd2e66900c017a3b2c72999ab61
https://github.com/WebKit/WebKit/commit/3dcd6c9672936bd2e66900c017a3b2c72999ab61
Author: Claudio Saavedra <[email protected]>
Date: 2026-01-30 (Fri, 30 Jan 2026)
Changed paths:
A LayoutTests/animations/animation-crash-expected.txt
A LayoutTests/animations/animation-crash.html
M Source/WebCore/animation/KeyframeEffect.cpp
Log Message:
-----------
Cherry-pick 306401@main (dcea00103e88).
https://bugs.webkit.org/show_bug.cgi?id=306445
KeyframeEffect: reduce scope of checked pointer
https://bugs.webkit.org/show_bug.cgi?id=306445
Reviewed by Geoffrey Garen and Anne van Kesteren.
After 305794@main introduced smart pointers in KeyframeEffect,
it's possible to hit an assertion when the checked pointer in
forceLayoutIfNeeded() goes out of scope at the end of the function.
Since this variable is only needed briefly, it's better to reduce its
scope as later calls in that method might delete the underlying
renderer object.
Test: animations/animation-crash.html
* LayoutTests/animations/animation-crash-expected.txt: Added.
* LayoutTests/animations/animation-crash.html: Added.
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::forceLayoutIfNeeded):
Canonical link: https://commits.webkit.org/306401@main
Canonical link: https://commits.webkit.org/305877.35@webkitglib/2.52
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
