Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 8d32ab8d183e71c3b32349fcc3f5a6436786b643
https://github.com/WebKit/WebKit/commit/8d32ab8d183e71c3b32349fcc3f5a6436786b643
Author: Kimmo Kinnunen <[email protected]>
Date: 2026-01-30 (Fri, 30 Jan 2026)
Changed paths:
M Source/WebCore/html/CanvasBase.cpp
M Source/WebCore/html/CanvasBase.h
M Source/WebCore/html/HTMLCanvasElement.cpp
M Source/WebCore/html/OffscreenCanvas.cpp
M Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp
Log Message:
-----------
Remove CanvasBase::m_contextStateSaver, it is not useful
https://bugs.webkit.org/show_bug.cgi?id=306603
rdar://169252451
Reviewed by Simon Fraser.
GraphicsContextStateSaver is a RAII class, it's not more useful than
explicit save/restore useful when managed explicitly. Having the state
saver in CanvasBase makes it harder to move the ImageBuffer from
CanvasBase to 2DCanvasRenderingContextBase.
* Source/WebCore/html/CanvasBase.cpp:
(WebCore::CanvasBase::setImageBuffer const):
(WebCore::CanvasBase::resetGraphicsContextState const): Deleted.
* Source/WebCore/html/CanvasBase.h:
* Source/WebCore/html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::didUpdateSizeProperties):
* Source/WebCore/html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::didUpdateSizeProperties):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::CanvasRenderingContext2DBase::unwindStateStack):
(WebCore::CanvasRenderingContext2DBase::reset):
Canonical link: https://commits.webkit.org/306511@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
