Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 02819ffe3a628b11cb32c23a12429d33a58b8fd4
https://github.com/WebKit/WebKit/commit/02819ffe3a628b11cb32c23a12429d33a58b8fd4
Author: Qianlang Chen <[email protected]>
Date: 2026-01-30 (Fri, 30 Jan 2026)
Changed paths:
M LayoutTests/http/tests/inspector/console/message-from-iframe-expected.txt
M LayoutTests/http/tests/inspector/console/message-from-iframe.html
M LayoutTests/inspector/console/clearMessages.html
M LayoutTests/inspector/console/messagesCleared.html
M LayoutTests/inspector/console/setConsoleClearAPIEnabled.html
M LayoutTests/inspector/console/webcore-logging.html
M LayoutTests/inspector/console/x-frame-options-message-expected.txt
M LayoutTests/inspector/console/x-frame-options-message.html
M LayoutTests/inspector/debugger/async-stack-trace-truncate-expected.txt
M LayoutTests/inspector/debugger/async-stack-trace-truncate.html
M LayoutTests/inspector/runtime/saveResult.html
M LayoutTests/inspector/shadow-realm-console-expected.txt
M LayoutTests/inspector/shadow-realm-console.html
M LayoutTests/platform/mac-site-isolation/TestExpectations
M Source/JavaScriptCore/inspector/protocol/Console.json
M Source/WebCore/CMakeLists.txt
M Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations
M Source/WebCore/Sources.txt
M Source/WebCore/WebCore.xcodeproj/project.pbxproj
M Source/WebCore/inspector/FrameInspectorController.cpp
M Source/WebCore/inspector/FrameInspectorController.h
M Source/WebCore/inspector/PageInspectorController.cpp
R Source/WebCore/inspector/agents/frame/FrameConsoleAgent.cpp
R Source/WebCore/inspector/agents/frame/FrameConsoleAgent.h
A Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp
A Source/WebCore/inspector/agents/page/PageConsoleAgent.h
M Source/WebCore/page/LocalFrame.cpp
M Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js
M Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js
M Source/WebInspectorUI/UserInterface/Protocol/Target.js
M Source/WebInspectorUI/UserInterface/Test/Test.js
M Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js
Log Message:
-----------
Web Inspector: Temporarily revert frame-target console work
https://bugs.webkit.org/show_bug.cgi?id=306590
Reviewed by BJ Burg.
Revert the work that implemented the console inspector domain for
frame targets and removed the implementation from page targets. The
change caused a sudden regression on old Safari when inspecting newly
built WebKit, where the console stopped working because the old
inspector only worked with the page target.
305725@main (the main work) and 304493@main (mark tests as progressed)
are reverted.
The plan is to rework and reland the said console work in a more
compatibility-friendly manner.
* LayoutTests/http/tests/inspector/console/message-from-iframe-expected.txt:
* LayoutTests/http/tests/inspector/console/message-from-iframe.html:
* LayoutTests/inspector/console/clearMessages.html:
* LayoutTests/inspector/console/messagesCleared.html:
* LayoutTests/inspector/console/setConsoleClearAPIEnabled.html:
* LayoutTests/inspector/console/webcore-logging.html:
* LayoutTests/inspector/console/x-frame-options-message-expected.txt:
* LayoutTests/inspector/console/x-frame-options-message.html:
* LayoutTests/inspector/debugger/async-stack-trace-truncate-expected.txt:
* LayoutTests/inspector/debugger/async-stack-trace-truncate.html:
* LayoutTests/inspector/runtime/saveResult.html:
* LayoutTests/inspector/shadow-realm-console-expected.txt:
* LayoutTests/inspector/shadow-realm-console.html:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
* Source/JavaScriptCore/inspector/protocol/Console.json:
* Source/WebCore/CMakeLists.txt:
* Source/WebCore/SaferCPPExpectations/UncountedCallArgsCheckerExpectations:
* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/inspector/FrameInspectorController.cpp:
(WebCore::FrameInspectorController::FrameInspectorController):
* Source/WebCore/inspector/FrameInspectorController.h:
* Source/WebCore/inspector/PageInspectorController.cpp:
(WebCore::PageInspectorController::PageInspectorController):
* Source/WebCore/inspector/agents/page/PageConsoleAgent.cpp: Renamed from
Source/WebCore/inspector/agents/frame/FrameConsoleAgent.cpp.
(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::getLoggingChannels):
(WebCore::PageConsoleAgent::setLoggingChannelLevel):
* Source/WebCore/inspector/agents/page/PageConsoleAgent.h: Renamed from
Source/WebCore/inspector/agents/frame/FrameConsoleAgent.h.
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::LocalFrame):
* Source/WebInspectorUI/UserInterface/Controllers/ConsoleManager.js:
(WI.ConsoleManager.prototype.initializeTarget):
(WI.ConsoleManager.prototype.messageWasAdded):
(WI.ConsoleManager.prototype.requestClearMessages):
* Source/WebInspectorUI/UserInterface/Protocol/RemoteObject.js:
(WI.RemoteObject):
* Source/WebInspectorUI/UserInterface/Protocol/Target.js:
(WI.Target.prototype.initialize):
* Source/WebInspectorUI/UserInterface/Test/Test.js:
* Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createConsoleSettingsView):
This commit include:
Revert "Web Inspector: Implement the Console domain and agent for the frame
target type"
This reverts commit 7face0d04d81d87f81283963bcf1664f7de6dd80.
Revert "Web Inspector: Unskip site isolation inspector tests progressed by
per-frame-target console work"
This reverts commit 6bf8cf927396ca0dba3d1288b29af1730d077523.
Canonical link: https://commits.webkit.org/306530@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
