Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c74593b7f29a219b0095c47e4b68906b85088d83
https://github.com/WebKit/WebKit/commit/c74593b7f29a219b0095c47e4b68906b85088d83
Author: Tim Nguyen <[email protected]>
Date: 2026-01-30 (Fri, 30 Jan 2026)
Changed paths:
M Source/WebCore/accessibility/AccessibilityMenuList.cpp
M Source/WebCore/html/HTMLOptGroupElement.cpp
M Source/WebCore/html/HTMLOptionElement.cpp
M Source/WebCore/html/HTMLSelectElement.cpp
M Source/WebCore/html/HTMLSelectElement.h
M Source/WebCore/rendering/RenderMenuList.cpp
M Source/WebCore/rendering/RenderMenuList.h
M Source/WebCore/testing/Internals.cpp
Log Message:
-----------
Move RenderMenuList popup handling to HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=306658
rdar://169307251
Reviewed by Ryosuke Niwa.
Reduce the amount of logic that RenderMenuList handles with the eventual goal
of removing RenderMenuList.
Split from Anne van Kesteren's PR: #57409
* Source/WebCore/accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::press):
(WebCore::AccessibilityMenuList::isCollapsed const):
* Source/WebCore/html/HTMLOptGroupElement.cpp:
* Source/WebCore/html/HTMLOptionElement.cpp:
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::didDetachRenderers):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer):
(WebCore::HTMLSelectElement::platformHandleKeydownEvent):
(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
(WebCore::HTMLSelectElement::showPopup):
(WebCore::HTMLSelectElement::hidePopup):
(WebCore::HTMLSelectElement::showPicker):
(WebCore::HTMLSelectElement::itemStyle const):
(WebCore::HTMLSelectElement::menuStyle const):
(WebCore::HTMLSelectElement::popupDidHide):
* Source/WebCore/html/HTMLSelectElement.h:
(WebCore::HTMLSelectElement::size const): Deleted.
(WebCore::HTMLSelectElement::multiple const): Deleted.
(WebCore::HTMLSelectElement::allowsNonContiguousSelection const): Deleted.
* Source/WebCore/rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::RenderMenuList):
(WebCore::RenderMenuList::updateFromElement):
(WebCore::RenderMenuList::willBeDestroyed): Deleted.
(WebCore::RenderMenuList::popupMenuSize): Deleted.
(WebCore::RenderMenuList::hostWindow const): Deleted.
(WebCore::RenderMenuList::showPopup): Deleted.
(WebCore::RenderMenuList::hidePopup): Deleted.
(WebCore::RenderMenuList::popupDidHide): Deleted.
* Source/WebCore/rendering/RenderMenuList.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::isSelectPopupVisible):
Co-authored-by: Anne van Kesteren <[email protected]>
Canonical link: https://commits.webkit.org/306546@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
