Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: beb5d48753ed3ba1ab8377a03c9232f4920d1fd2
https://github.com/WebKit/WebKit/commit/beb5d48753ed3ba1ab8377a03c9232f4920d1fd2
Author: Tim Nguyen <[email protected]>
Date: 2026-01-30 (Fri, 30 Jan 2026)
Changed paths:
M Source/WebCore/html/HTMLSelectElement.cpp
Log Message:
-----------
Clean up `HTMLSelectElement::defaultEventHandler`
https://bugs.webkit.org/show_bug.cgi?id=306675
rdar://169320494
Reviewed by Ryosuke Niwa.
We already conditionally create RenderListBox in
`HTMLSelectElement::createElementRenderer`, so the platform checks in
`HTMLSelectElement::defaultEventHandler` were just redundant. We can just use
`is<RenderMenuList>` and get the same info.
The isDisabledFormControl() short-circuit is also relevant on iOS, we were
previously doing useless work before on iOS for disabled selects.
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler):
Canonical link: https://commits.webkit.org/306549@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
