Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: c5a53c2a96c1bd48c7e0ec52fb362a1475f3f244
https://github.com/WebKit/WebKit/commit/c5a53c2a96c1bd48c7e0ec52fb362a1475f3f244
Author: Megan Gardner <[email protected]>
Date: 2026-01-31 (Sat, 31 Jan 2026)
Changed paths:
M Source/WebCore/page/FocusController.cpp
M Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm
Log Message:
-----------
Focusing a cross-origin iFrame on iOS results in an unintended focus on
iframe.
https://bugs.webkit.org/show_bug.cgi?id=306660
rdar://169310024
Reviewed by Alex Christensen.
This is a continuation of 306434@main.
I should have had more guards for side effects
in findFocusableElementInDocumentOrderStartingWithFrame.
Adding the guard for all side-effects fixes the
test, and is more logically sound, since we can
get here when we are only looking for the next
or previous element, that should not result in focus,
selection or focused frame changing.
Test: Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::findFocusableElementInDocumentOrderStartingWithFrame):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/FocusWebView.mm:
Canonical link: https://commits.webkit.org/306566@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
