[webkit-changes] [WebKit/WebKit] d78067: Remove unused PopupMenuClient methods

[Tim Nguyen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d7806750ee1ba6a007d630421844da59c2f028cf
      
https://github.com/WebKit/WebKit/commit/d7806750ee1ba6a007d630421844da59c2f028cf
  Author: Tim Nguyen <n...@apple.com>
  Date:   2026-01-31 (Sat, 31 Jan 2026)

  Changed paths:
    M Source/WebCore/html/HTMLSelectElement.cpp
    M Source/WebCore/html/HTMLSelectElement.h
    M Source/WebCore/html/SearchInputType.cpp
    M Source/WebCore/html/SearchInputType.h
    M Source/WebCore/platform/PopupMenuClient.h
    M Source/WebCore/rendering/RenderMenuList.cpp
    M Source/WebCore/rendering/RenderMenuList.h
    M Source/WebCore/rendering/RenderSearchField.cpp
    M Source/WebCore/rendering/RenderSearchField.h
    M Source/WebCore/rendering/RenderSelectFallbackButton.cpp

  Log Message:
  -----------
  Remove unused PopupMenuClient methods
https://bugs.webkit.org/show_bug.cgi?id=306680
rdar://169330035

Reviewed by Tim Horton.

There are no call-sites, remove them for easier maintenance.

Put Windows-only methods behind `PLATFORM(WIN)` check.

* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::clientInsetLeft const):
(WebCore::HTMLSelectElement::clientInsetRight const):
(WebCore::HTMLSelectElement::clientPaddingLeft const):
(WebCore::HTMLSelectElement::clientPaddingRight const):
(WebCore::HTMLSelectElement::itemLabel const): Deleted.
(WebCore::HTMLSelectElement::itemIcon const): Deleted.
(WebCore::HTMLSelectElement::popupSelectedIndex const): Deleted.
(WebCore::HTMLSelectElement::listBoxSelectItem): Deleted.
(WebCore::HTMLSelectElement::createScrollbar): Deleted.
* Source/WebCore/html/HTMLSelectElement.h:
* Source/WebCore/html/SearchInputType.cpp:
(WebCore::SearchInputType::fontSelector const):
(WebCore::SearchInputType::hostWindow const):
(WebCore::SearchInputType::itemLabel const): Deleted.
(WebCore::SearchInputType::itemIcon const): Deleted.
(WebCore::SearchInputType::popupSelectedIndex const): Deleted.
(WebCore::SearchInputType::createScrollbar): Deleted.
* Source/WebCore/html/SearchInputType.h:
* Source/WebCore/platform/PopupMenuClient.h:
(WebCore::PopupMenuClient::listBoxSelectItem): Deleted.
(WebCore::PopupMenuClient::popupMultiple const): Deleted.
* Source/WebCore/rendering/RenderMenuList.cpp:
* Source/WebCore/rendering/RenderMenuList.h:
* Source/WebCore/rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::popupDidHide):
* Source/WebCore/rendering/RenderSearchField.h:
* Source/WebCore/rendering/RenderSelectFallbackButton.cpp:
(WebCore::RenderSelectFallbackButton::updateFromElement):

Canonical link: https://commits.webkit.org/306583@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications