Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: b7056c34cbe99f896f0dd1016cd57f386e05e7ca
https://github.com/WebKit/WebKit/commit/b7056c34cbe99f896f0dd1016cd57f386e05e7ca
Author: Chris Dumez <[email protected]>
Date: 2026-02-01 (Sun, 01 Feb 2026)
Changed paths:
M Source/WebCore/accessibility/AXObjectCache.cpp
M Source/WebCore/dom/ContainerNode.cpp
M Source/WebCore/dom/ContainerNode.h
M Source/WebCore/dom/ContainerNodeInlines.h
M Source/WebCore/dom/CustomElementDefaultARIA.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/DocumentFragment.cpp
M Source/WebCore/dom/Element.cpp
M Source/WebCore/dom/ElementRareData.h
M Source/WebCore/dom/Node.cpp
M Source/WebCore/dom/Node.h
M Source/WebCore/dom/NodeInlines.h
M Source/WebCore/dom/Range.cpp
M Source/WebCore/dom/SerializedNode.cpp
M Source/WebCore/dom/StaticRange.cpp
M Source/WebCore/dom/Text.cpp
M Source/WebCore/editing/ApplyStyleCommand.cpp
M Source/WebCore/editing/ChangeListTypeCommand.cpp
M Source/WebCore/editing/CompositeEditCommand.cpp
M Source/WebCore/editing/EditingStyle.cpp
M Source/WebCore/editing/SplitTextNodeCommand.cpp
M Source/WebCore/editing/TextIterator.cpp
M Source/WebCore/editing/cocoa/EditingHTMLConverter.mm
M Source/WebCore/editing/markup.cpp
M Source/WebCore/html/FormAssociatedCustomElement.cpp
M Source/WebCore/html/FormListedElement.cpp
M Source/WebCore/html/HTMLDetailsElement.cpp
M Source/WebCore/html/HTMLHRElement.cpp
M Source/WebCore/html/HTMLImageElement.cpp
M Source/WebCore/html/HTMLOptGroupElement.cpp
M Source/WebCore/html/HTMLOptionElement.cpp
M Source/WebCore/html/HTMLTableElement.cpp
M Source/WebCore/html/HTMLTextAreaElement.cpp
M Source/WebCore/html/MediaDocument.cpp
M Source/WebCore/html/RadioInputType.cpp
M Source/WebCore/html/SearchInputType.cpp
M Source/WebCore/html/shadow/SpatialImageControls.cpp
M Source/WebCore/html/shadow/SpinButtonElement.cpp
M Source/WebCore/html/shadow/TextControlInnerElements.cpp
M Source/WebCore/inspector/DOMPatchSupport.cpp
M Source/WebCore/inspector/agents/InspectorDOMAgent.cpp
M Source/WebCore/page/DOMSelection.cpp
M Source/WebCore/rendering/mac/RenderThemeMac.mm
M Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp
M Source/WebCore/svg/SVGTRefElement.cpp
M Source/WebCore/svg/SVGUseElement.cpp
M Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
M Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm
Log Message:
-----------
Drop `protected*()` getters in Node.h
https://bugs.webkit.org/show_bug.cgi?id=306718
Reviewed by Anne van Kesteren.
Use `protect()` at call sites instead.
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::addRelation):
* Source/WebCore/dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeAllChildrenWithScriptAssertion):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* Source/WebCore/dom/ContainerNode.h:
(WebCore::ContainerNode::firstChild const):
(WebCore::ContainerNode::lastChild const):
(WebCore::ContainerNode::protectedFirstChild const): Deleted.
(WebCore::ContainerNode::protectedLastChild const): Deleted.
* Source/WebCore/dom/ContainerNodeInlines.h:
(WebCore::ContainerNode::protectedRootNode const): Deleted.
* Source/WebCore/dom/CustomElementDefaultARIA.cpp:
(WebCore::isElementVisible):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::setTitle):
* Source/WebCore/dom/DocumentFragment.cpp:
(WebCore::DocumentFragment::getElementById const):
* Source/WebCore/dom/Element.cpp:
* Source/WebCore/dom/ElementRareData.h:
(WebCore::Node::protectedShadowRoot const): Deleted.
* Source/WebCore/dom/Node.cpp:
(WebCore::Node::protectedShadowHost const): Deleted.
(WebCore::Node::protectedContainingShadowRoot const): Deleted.
* Source/WebCore/dom/Node.h:
(WebCore::Node::previousSibling const):
(WebCore::Node::nextSibling const):
(WebCore::Node::treeScope const):
(WebCore::Node::protectedPreviousSibling const): Deleted.
(WebCore::Node::protectedNextSibling const): Deleted.
* Source/WebCore/dom/NodeInlines.h:
(WebCore::Node::protectedParentOrShadowHostNode const): Deleted.
(WebCore::Node::protectedScriptExecutionContext const): Deleted.
(WebCore::Node::protectedTreeScope const): Deleted.
(WebCore::Node::protectedParentElement const): Deleted.
(WebCore::Node::protectedFirstChild const): Deleted.
(WebCore::Node::protectedLastChild const): Deleted.
(WebCore::Node::protectedRootNode const): Deleted.
(WebCore::Node::protectedParentNode const): Deleted.
* Source/WebCore/dom/Range.cpp:
(WebCore::Range::processContents):
(WebCore::processAncestorsAndTheirSiblings):
(WebCore::boundaryTextNodesMerged):
(WebCore::boundaryTextNodesSplit):
* Source/WebCore/dom/SerializedNode.cpp:
(WebCore::SerializedNode::deserialize):
* Source/WebCore/dom/StaticRange.cpp:
(WebCore::StaticRange::computeValidity const):
* Source/WebCore/dom/Text.cpp:
(WebCore::Text::splitText):
* Source/WebCore/editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
* Source/WebCore/editing/ChangeListTypeCommand.cpp:
(WebCore::ChangeListTypeCommand::doApply):
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
* Source/WebCore/editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
* Source/WebCore/editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::insertText1AndTrimText2):
* Source/WebCore/editing/TextIterator.cpp:
(WebCore::TextIterator::handleReplacedElement):
(WebCore::TextIterator::exitNode):
(WebCore::SimplifiedBackwardsTextIterator::advance):
(WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
(WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
* Source/WebCore/editing/cocoa/EditingHTMLConverter.mm:
(WebCore::hasAncestorQualifyingForWritingToolsPreservation):
(WebCore::updateAttributes):
* Source/WebCore/editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::isPlainTextMarkup):
* Source/WebCore/html/FormAssociatedCustomElement.cpp:
(WebCore::FormAssociatedCustomElement::didUpgrade):
* Source/WebCore/html/FormListedElement.cpp:
(WebCore::FormAttributeTargetObserver::FormAttributeTargetObserver):
* Source/WebCore/html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::isActiveSummary const):
* Source/WebCore/html/HTMLHRElement.cpp:
(WebCore::HTMLHRElement::insertedIntoAncestor):
(WebCore::HTMLHRElement::removedFromAncestor):
* Source/WebCore/html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::insertedIntoAncestor):
(WebCore::HTMLImageElement::removedFromAncestor):
(WebCore::HTMLImageElement::associatedMapElement const):
* Source/WebCore/html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::insertedIntoAncestor):
(WebCore::HTMLOptGroupElement::removedFromAncestor):
* Source/WebCore/html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::insertedIntoAncestor):
(WebCore::HTMLOptionElement::removedFromAncestor):
* Source/WebCore/html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::setCaption):
* Source/WebCore/html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::updatePlaceholderText):
* Source/WebCore/html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired):
* Source/WebCore/html/RadioInputType.cpp:
(WebCore::RadioInputType::valueMissing const):
* Source/WebCore/html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree):
* Source/WebCore/html/shadow/SpatialImageControls.cpp:
(WebCore::SpatialImageControls::ensureSpatialControls):
* Source/WebCore/html/shadow/SpinButtonElement.cpp:
(WebCore::SpinButtonElement::matchesReadWritePseudoClass const):
* Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlPlaceholderElement::resolveCustomStyle):
* Source/WebCore/inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
(WebCore::DOMPatchSupport::removeChildAndMoveToNew):
* Source/WebCore/inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeName):
* Source/WebCore/page/DOMSelection.cpp:
(WebCore::DOMSelection::getComposedRanges):
* Source/WebCore/rendering/mac/RenderThemeMac.mm:
(WebCore::RenderThemeMac::setColorWellSwatchBackground):
* Source/WebCore/rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::gradientElement):
* Source/WebCore/svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::updateReferencedText):
* Source/WebCore/svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandUseElementsInShadowTree const):
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree const):
* Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
* Source/WebKit/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm:
(-[WKDOMNode parentNode]):
(-[WKDOMNode firstChild]):
(-[WKDOMNode lastChild]):
(-[WKDOMNode previousSibling]):
(-[WKDOMNode nextSibling]):
Canonical link: https://commits.webkit.org/306609@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
