Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3e6b56ba17b7d642a8427e055928104c23f6ce22
https://github.com/WebKit/WebKit/commit/3e6b56ba17b7d642a8427e055928104c23f6ce22
Author: Jer Noble <[email protected]>
Date: 2026-02-02 (Mon, 02 Feb 2026)
Changed paths:
M Source/WebCore/page/CaptionUserPreferences.cpp
M Source/WebCore/platform/MediaSelectionOption.h
M Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKitLegacy.mm
M Source/WebCore/platform/ios/WebAVPlayerController.h
M Source/WebCore/platform/ios/WebAVPlayerController.mm
M Source/WebCore/platform/mac/WebPlaybackControlsManager.mm
M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
Log Message:
-----------
[Cocoa] Subtitles language label shows "Not available" for some videos
rdar://168726531
https://bugs.webkit.org/show_bug.cgi?id=306623
Reviewed by Eric Carlson.
AVKit needs locale information in order to correctly build the track
list UI, which means WebKit needs to pipe the language code provided
by the track up to the UIProcess as part of the synthetic
WebAVMediaSelectionOption we pass to the AVPlayerViewController.
* Source/WebCore/page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::mediaSelectionOptionForTrack const):
* Source/WebCore/platform/MediaSelectionOption.h:
(WebCore::MediaSelectionOption::MediaSelectionOption):
(WebCore::MediaSelectionOption::isolatedCopy const):
(WebCore::MediaSelectionOption::isolatedCopy):
* Source/WebCore/platform/ios/PlaybackSessionInterfaceAVKitLegacy.mm:
(WebCore::mediaSelectionOptions):
* Source/WebCore/platform/ios/WebAVPlayerController.h:
* Source/WebCore/platform/ios/WebAVPlayerController.mm:
(-[WebAVMediaSelectionOption
initWithMediaType:displayName:extendedLanguageTag:]):
(-[WebAVMediaSelectionOption copyWithZone:]):
(-[WebAVMediaSelectionOption extendedLanguageTag]):
(-[WebAVMediaSelectionOption locale]):
(-[WebAVMediaSelectionOption languageCode]):
(-[WebAVMediaSelectionOption initWithMediaType:displayName:]): Deleted.
* Source/WebCore/platform/mac/WebPlaybackControlsManager.mm:
(toAVTouchBarMediaSelectionOptionType):
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
Canonical link: https://commits.webkit.org/306658@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
