Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 54ea44e1a5a34031a0419e70149deed3cb5e17eb
https://github.com/WebKit/WebKit/commit/54ea44e1a5a34031a0419e70149deed3cb5e17eb
Author: Chris Dumez <[email protected]>
Date: 2026-02-03 (Tue, 03 Feb 2026)
Changed paths:
R Source/WebKit/Shared/LogStream.cpp
A Source/WebKit/Shared/LogStream.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
Log Message:
-----------
Address Safer CPP warnings in LogMessagesImplementations.h
https://bugs.webkit.org/show_bug.cgi?id=306919
Reviewed by Darin Adler and Ryosuke Niwa.
There are a lot of warnings in this generated header about using adoptNS()
when unnecessary. However, the code is correct and the real issue is that
this header is included in a cpp file instead of a mm file. This was
causing the annotation that the static analyzer relies on to not work.
* Source/WebKit/Shared/LogStream.mm: Renamed from
Source/WebKit/Shared/LogStream.cpp.
(WebKit::LogStream::LogStream):
(WebKit::LogStream::stopListeningForIPC):
(WebKit::LogStream::logOnBehalfOfWebContent):
(WebKit::LogStream::create):
(WebKit::LogStream::didReceiveInvalidMessage):
(WebKit::LogStream::logCountForTesting):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
Canonical link: https://commits.webkit.org/306756@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
