Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: d96a37b422a93754acd5707aa58c5f3f259b4b26
https://github.com/WebKit/WebKit/commit/d96a37b422a93754acd5707aa58c5f3f259b4b26
Author: David Kilzer <[email protected]>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h
Log Message:
-----------
REGRESSION (283678@main): WebKit::RemoteImageBufferSet contains duplicate
m_previouslyPaintedRect member variable from base class
<https://bugs.webkit.org/show_bug.cgi?id=306936>
<rdar://problem/169600258>
Reviewed by Alan Baradlay.
The `m_previouslyPaintedRect` member variable is declared in both
`WebKit::ImageBufferSet` (base class) and `WebKit::RemoteImageBufferSet`
(subclass), causing the subclass member to shadow the base class member.
This can lead to subtle bugs where code in the base class writes to its
member while the subclass reads its own shadowed member (or vice versa).
The duplicate was introduced when commit 283678@main extracted
`ImageBufferSet` as a base class and moved several member variables from
`RemoteImageBufferSet` to the base class, but failed to remove
`m_previouslyPaintedRect` from the subclass.
The fix is to remove `m_previouslyPaintedRect` from
`WebKit::RemoteImageBufferSet`.
No new tests since no change in behavior.
* Source/WebKit/GPUProcess/graphics/RemoteImageBufferSet.h:
Canonical link: https://commits.webkit.org/306794@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
