Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: e7355a932f3e942e7f84321eeca310cfe9215dcc
https://github.com/WebKit/WebKit/commit/e7355a932f3e942e7f84321eeca310cfe9215dcc
Author: Jer Noble <[email protected]>
Date: 2026-02-04 (Wed, 04 Feb 2026)
Changed paths:
M
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp
M
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h
M
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Log Message:
-----------
[Cocoa] Adopt AVPlayer.participatesInAudioSession
rdar://169639828
https://bugs.webkit.org/show_bug.cgi?id=306969
Reviewed by Andy Estes and Eric Carlson.
Disable participation in AVAudioSessions when the underlying player is muted,
has zero
volume, or doesn't contain an enabled audio track.
Drive-by fixes:
- Cache the value of player->volume() locally and set the initial volume when
creating
the AVPlayer.
- Only call setVolume: on AVPlayer if the volume actually changed.
*
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::setHasAudio):
*
Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
*
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume):
(WebCore::MediaPlayerPrivateAVFoundationObjC::setMuted):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateIsAudible):
Canonical link: https://commits.webkit.org/306825@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
