[webkit-changes] [WebKit/WebKit] be1dc6: [WGSL] Validate override initializers in variable ...

Thu, 05 Feb 2026 01:27:42 -0800 

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be1dc6f27b7112a723c8c3f5426a8b44d88f8666
      
https://github.com/WebKit/WebKit/commit/be1dc6f27b7112a723c8c3f5426a8b44d88f8666
  Author: Tadeu Zagallo <[email protected]>
  Date:   2026-02-05 (Thu, 05 Feb 2026)

  Changed paths:
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/acos-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/acosh-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/asin-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/atanh-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/clamp-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/cosh-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/cross-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/degrees-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/distance-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/dot-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/exp-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/exp2-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/faceForward-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/fma-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/inverseSqrt-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/ldexp-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/length-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/log-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/log2-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/mix-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/pack2x16float-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/pow-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/quantizeToF16-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/reflect-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/refract-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/sinh-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/smoothstep-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/sqrt-expected.txt
    M 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/unpack2x16float-expected.txt
    M LayoutTests/platform/mac-wk2/TestExpectations
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/WGSL.cpp
    M Source/WebGPU/WGSL/WGSL.h
    M Source/WebGPU/WGSL/WGSLShaderModule.cpp
    M Source/WebGPU/WGSL/WGSLShaderModule.h

  Log Message:
  -----------
  [WGSL] Validate override initializers in variable declarations
https://bugs.webkit.org/show_bug.cgi?id=306947
rdar://169610434

Reviewed by Mike Wyrzykowski.

This caused most of the CTS failures under 
shader/validation/expression/call/builtin/*
since no validation errors were reported when using an invalid override call to 
initialize
a variable, e.g. `override x = -1; var v = sqrt(x)`.

* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/acos-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/acosh-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/asin-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/atanh-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/clamp-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/cosh-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/cross-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/degrees-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/distance-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/dot-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/exp-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/exp2-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/faceForward-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/fma-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/inverseSqrt-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/ldexp-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/length-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/log-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/log2-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/mix-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/pack2x16float-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/pow-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/quantizeToF16-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/reflect-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/refract-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/sinh-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/smoothstep-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/sqrt-expected.txt:
* 
LayoutTests/http/tests/webgpu/webgpu/shader/validation/expression/call/builtin/unpack2x16float-expected.txt:
* LayoutTests/platform/mac-wk2/TestExpectations:
* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::visitEntryPoint):
(WGSL::RewriteGlobalVariables::validateUsedGlobals const):
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::evaluate):
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WGSL/WGSLShaderModule.cpp:
(WGSL::ShaderModule::ensureOverrideValue const):
(WGSL::ShaderModule::validateOverrides):
(WGSL::ShaderModule::lookupOverload const):
(WGSL::ShaderModule::lookupOverload): Deleted.
* Source/WebGPU/WGSL/WGSLShaderModule.h:

Canonical link: https://commits.webkit.org/306846@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to