Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7efbf82793dde81b2ce87e606296f2f8b561063f
      
https://github.com/WebKit/WebKit/commit/7efbf82793dde81b2ce87e606296f2f8b561063f
  Author: Alex Christensen <[email protected]>
  Date:   2026-02-05 (Thu, 05 Feb 2026)

  Changed paths:
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm

  Log Message:
  -----------
  [macOS] TestWebKitAPI.WKDownload.DownloadRequestFailure is flaky failure
https://bugs.webkit.org/show_bug.cgi?id=305855
rdar://168517549

Reviewed by Tim Horton.

Creating a server on a port, then cancelling the server, then connecting to the 
port
and hoping nothing else had done anything with that port is mostly reliable, 
but not
reliable enough for running tests on our bots.  This test needs to verify what 
happens
when the download hits a network error, so I'm switching to 
NSURLErrorNetworkConnectionLost
which I can hit more reliably by keeping the server running but terminating any 
incoming
connections.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
(TestWebKitAPI::DownloadRequestFailure)):

Canonical link: https://commits.webkit.org/306906@main



To unsubscribe from these emails, change your notification settings at 
https://github.com/WebKit/WebKit/settings/notifications

Reply via email to