Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2c6b880e689100e64b73769f5b22991b8d90cdd4
https://github.com/WebKit/WebKit/commit/2c6b880e689100e64b73769f5b22991b8d90cdd4
Author: Said Abou-Hallawa <[email protected]>
Date: 2026-02-05 (Thu, 05 Feb 2026)
Changed paths:
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-dynamic-expected.html
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-dynamic.html
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-image-expected.html
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-image.html
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-text-expected.html
A
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-text.html
M
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-dynamic-expected.html
M
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-dynamic.html
M
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-initial.html
M Source/WebCore/rendering/style/RenderStyle.cpp
M Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdater.h
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp
M Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.h
Log Message:
-----------
[appearance: base] Support `content` CSS property for ::checkmark
https://bugs.webkit.org/show_bug.cgi?id=305892
rdar://168599335
Reviewed by Tim Nguyen.
A new renderer will be created to display the content of the pseudo element
::checkmark. Unlike the pseudo elements '::before' and `::after` no DOM pseudo
element will be created to host the content renderer. It will be just a child
of the renderer of the pseudo element ::checkmark.
Test:
fast/forms/appearance-base/appearance-base-checkable-checkmark-content-dynamic.html
fast/forms/appearance-base/appearance-base-checkable-checkmark-content-image.html
fast/forms/appearance-base/appearance-base-checkable-checkmark-content-text.html
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-dynamic-expected.html:
Added.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-dynamic.html:
Added.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-image-expected.html:
Added.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-image.html:
Added.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-text-expected.html:
Added.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-content-text.html:
Added.
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-dynamic-expected.html:
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-dynamic.html:
*
LayoutTests/fast/forms/appearance-base/appearance-base-checkable-checkmark-initial.html:
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::createStyleInheritingFromPseudoStyle):
* Source/WebCore/rendering/updating/RenderTreeBuilderFormControls.cpp:
(WebCore::RenderTreeBuilder::FormControls::updateCheckmark):
* Source/WebCore/rendering/updating/RenderTreeUpdater.h:
* Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:
(WebCore::RenderTreeUpdater::GeneratedContent::createContentRenderers):
(WebCore::RenderTreeUpdater::GeneratedContent::updateStyleForContentRenderers):
(WebCore::createContentRenderers): Deleted.
(WebCore::updateStyleForContentRenderers): Deleted.
* Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.h:
Canonical link: https://commits.webkit.org/306912@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
