Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 0c810684f3c6ae629087f18ae4a0daf75bf2ca3e
https://github.com/WebKit/WebKit/commit/0c810684f3c6ae629087f18ae4a0daf75bf2ca3e
Author: Tim Nguyen <[email protected]>
Date: 2026-02-05 (Thu, 05 Feb 2026)
Changed paths:
M Source/WebCore/html/HTMLSelectElement.cpp
Log Message:
-----------
Use `m_multiple` in `HTMLSelectElement::selectAll()` and
`HTMLSelectElement::canSelectAll()`
https://bugs.webkit.org/show_bug.cgi?id=307108
rdar://169741302
Reviewed by Aditya Keerthi.
`usesMenuList()` currently returns false on iOS when m_multiple is true,
despite the platform showing a menulist.
Replace the checks with `m_multiple` to clarify intent. This also changes macOS
behavior, where for size > 1, we now no longer allow the selectAll command.
By reducing misleading usages of `usesMenuList()`, we can fix its definition
later.
Covered by existing tests.
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::canSelectAll const):
(WebCore::HTMLSelectElement::selectAll):
Canonical link: https://commits.webkit.org/306916@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
