Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3b2e1cd77ab8b0a9a2ec8d439943a86ea19772e7
https://github.com/WebKit/WebKit/commit/3b2e1cd77ab8b0a9a2ec8d439943a86ea19772e7
Author: Chris Dumez <[email protected]>
Date: 2026-02-06 (Fri, 06 Feb 2026)
Changed paths:
M Source/WebCore/css/CSSFontSelector.h
M Source/WebCore/css/CSSGridLineValue.cpp
M Source/WebCore/css/CSSGridLineValue.h
M Source/WebCore/css/CSSGroupingRule.cpp
M Source/WebCore/css/CSSGroupingRule.h
M Source/WebCore/css/CSSImageSetOptionValue.h
M Source/WebCore/css/CSSImageSetValue.cpp
M Source/WebCore/css/CSSImportRule.cpp
M Source/WebCore/css/CSSImportRule.h
M Source/WebCore/css/CSSMediaRule.cpp
M Source/WebCore/css/CSSPositionTryRule.cpp
M Source/WebCore/css/CSSPositionTryRule.h
M Source/WebCore/css/CSSPrimitiveValue.cpp
M Source/WebCore/css/CSSPrimitiveValue.h
M Source/WebCore/css/CSSProperty.h
M Source/WebCore/css/CSSToLengthConversionData.cpp
M Source/WebCore/css/CSSToLengthConversionData.h
M Source/WebCore/css/StyleProperties.h
M Source/WebCore/css/StyleRule.cpp
M Source/WebCore/css/StyleRule.h
M Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp
M Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp
M Source/WebCore/css/parser/CSSPropertyParser.cpp
M Source/WebCore/css/query/GenericMediaQuerySerialization.cpp
M Source/WebCore/css/query/GenericMediaQueryTypes.h
M Source/WebCore/editing/EditingStyle.cpp
M Source/WebCore/html/track/WebVTTParser.cpp
M Source/WebCore/page/PageSerializer.cpp
M Source/WebCore/style/calc/StyleCalculationTree+Conversion.cpp
M Source/WebCore/style/values/inline/StyleLineHeight.cpp
M
Source/WebCore/style/values/primitives/StyleLengthWrapper+CSSValueConversion.h
M
Source/WebCore/style/values/primitives/StyleLengthWrapper+DeprecatedCSSValueConversion.h
M
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+CSSValueConversion.h
M Source/WebCore/style/values/text/StyleLetterSpacing.cpp
M Source/WebCore/style/values/text/StyleWordSpacing.cpp
M Source/WebCore/style/values/transforms/StyleTransformFunction.cpp
Log Message:
-----------
Reduce use of protected functions in Source/WebCore/css
https://bugs.webkit.org/show_bug.cgi?id=307126
Reviewed by Ryosuke Niwa.
Reduce use of protected functions in Source/WebCore/css and adopt `protect()`
at call sites instead.
* Source/WebCore/css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered):
* Source/WebCore/css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::fontFaceSet):
(WebCore::CSSFontSelector::addFontFaceRule):
(WebCore::CSSFontSelector::resolveGenericFamily):
(WebCore::CSSFontSelector::fontRangesForFamily):
(WebCore::CSSFontSelector::fallbackFontCount):
* Source/WebCore/css/CSSFontSelector.h:
* Source/WebCore/css/CSSGridLineValue.cpp:
(WebCore::CSSGridLineValue::equals const):
* Source/WebCore/css/CSSGridLineValue.h:
* Source/WebCore/css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::protectedGroupRule const): Deleted.
(WebCore::CSSGroupingRule::protectedGroupRule): Deleted.
* Source/WebCore/css/CSSGroupingRule.h:
(WebCore::CSSGroupingRule::groupRule):
* Source/WebCore/css/CSSImageSetOptionValue.h:
* Source/WebCore/css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::createStyleImage const):
* Source/WebCore/css/CSSImportRule.cpp:
(WebCore::CSSImportRule::protectedStyleSheet const): Deleted.
* Source/WebCore/css/CSSImportRule.h:
* Source/WebCore/css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::setMediaQueries):
* Source/WebCore/css/CSSPositionTryRule.cpp:
(WebCore::StyleRulePositionTry::StyleRulePositionTry):
(WebCore::CSSPositionTryRule::reattach):
* Source/WebCore/css/CSSPositionTryRule.h:
* Source/WebCore/css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::stringValue const):
(WebCore::CSSPrimitiveValue::serializeInternal const):
(WebCore::CSSPrimitiveValue::equals const):
* Source/WebCore/css/CSSPrimitiveValue.h:
* Source/WebCore/css/CSSProperty.h:
(WebCore::CSSProperty::value const):
(WebCore::CSSProperty::protectedValue const): Deleted.
* Source/WebCore/css/CSSToLengthConversionData.cpp:
(WebCore::CSSToLengthConversionData::protectedStyleBuilderState const): Deleted.
* Source/WebCore/css/CSSToLengthConversionData.h:
(WebCore::CSSToLengthConversionData::styleBuilderState const):
* Source/WebCore/css/StyleProperties.h:
(WebCore::StyleProperties::PropertyReference::value):
(WebCore::StyleProperties::PropertyReference::toCSSProperty const):
(WebCore::StyleProperties::PropertyReference::protectedValue const): Deleted.
* Source/WebCore/css/StyleRule.cpp:
(WebCore::StyleRule::protectedProperties const): Deleted.
* Source/WebCore/css/StyleRule.h:
(WebCore::StyleRule::properties const):
* Source/WebCore/css/calc/CSSCalcTree+Evaluation.cpp:
(WebCore::CSSCalc::evaluate):
* Source/WebCore/css/calc/CSSCalcTree+Simplification.cpp:
(WebCore::CSSCalc::simplify):
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeInternalAutoBaseFunction):
* Source/WebCore/css/query/GenericMediaQuerySerialization.cpp:
(WebCore::MQ::serialize):
* Source/WebCore/css/query/GenericMediaQueryTypes.h:
(WebCore::MQ::Comparison::protectedValue const): Deleted.
* Source/WebCore/editing/EditingStyle.cpp:
(WebCore::EditingStyle::mergeStyle):
(WebCore::styleFromMatchedRulesForElement):
* Source/WebCore/html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::checkAndStoreStyleSheet):
* Source/WebCore/page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeCSSStyleSheet):
(WebCore::PageSerializer::retrieveResourcesForRule):
* Source/WebCore/style/calc/StyleCalculationTree+Conversion.cpp:
(WebCore::Style::Calculation::toStyle):
* Source/WebCore/style/values/inline/StyleLineHeight.cpp:
(WebCore::Style::CSSValueConversion<LineHeight>::operator):
*
Source/WebCore/style/values/primitives/StyleLengthWrapper+CSSValueConversion.h:
(WebCore::Style::CSSValueConversion<T>::operator()):
*
Source/WebCore/style/values/primitives/StyleLengthWrapper+DeprecatedCSSValueConversion.h:
(WebCore::Style::DeprecatedCSSValueConversion<T>::operator()):
*
Source/WebCore/style/values/primitives/StylePrimitiveNumericTypes+CSSValueConversion.h:
* Source/WebCore/style/values/text/StyleLetterSpacing.cpp:
(WebCore::Style::CSSValueConversion<LetterSpacing>::operator):
* Source/WebCore/style/values/text/StyleWordSpacing.cpp:
(WebCore::Style::CSSValueConversion<WordSpacing>::operator):
* Source/WebCore/style/values/transforms/StyleTransformFunction.cpp:
(WebCore::Style::resolveAsTranslateLengthPercentage):
Canonical link: https://commits.webkit.org/306934@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
