Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ca777294b75cb76c1f4dd6b8436fa7980d7f6cf4
https://github.com/WebKit/WebKit/commit/ca777294b75cb76c1f4dd6b8436fa7980d7f6cf4
Author: Aakash Jain <[email protected]>
Date: 2026-02-06 (Fri, 06 Feb 2026)
Changed paths:
M Tools/CISupport/ews-build/config.json
M Tools/CISupport/ews-build/factories.py
M Tools/CISupport/ews-build/loadConfig.py
M Tools/CISupport/ews-build/loadConfig_unittest.py
M Tools/CISupport/ews-build/steps.py
M Tools/CISupport/ews-build/steps_unittest.py
Log Message:
-----------
[ews] Add support for multiple builders for the feature of rebuilding for
retries on builder queue
https://bugs.webkit.org/show_bug.cgi?id=306627
rdar://169286969
Reviewed by Elliott Williams and Brianna Fan.
Replace the hardcoded MACOS_SEQUOIA_TRIGGER and MACOS_SEQUOIA_BUILDER_NAME
constants
with a config-driven approach using a new `rebuild_without_change_on_builder`
flag.
This flag is set on builder queues in config.json, flows through the build
system as
a build property, and is passed to triggered tester builds so they know to
download
pre-built products instead of recompiling locally. This makes it
straightforward to
enable the same behavior on additional builders without code changes.
* Tools/CISupport/ews-build/config.json: Add
`rebuild_without_change_on_builder: true`
to the macOS-Sequoia-Release-Build-EWS builder entry.
* Tools/CISupport/ews-build/factories.py: Accept and forward the new
`rebuild_without_change_on_builder` parameter through Factory and BuildFactory
to ConfigureBuild.
* Tools/CISupport/ews-build/loadConfig.py: Extract
`rebuild_without_change_on_builder`
from builder config and add validation ensuring it is only set on builders that
have triggers.
* Tools/CISupport/ews-build/loadConfig_unittest.py: Add
`rebuild_without_change_on_builder`
to valid builder keys. Add tests for the new validation rule.
* Tools/CISupport/ews-build/steps.py: Remove MACOS_SEQUOIA_TRIGGER and
MACOS_SEQUOIA_BUILDER_NAME constants. Update ConfigureBuild to accept, store,
and set `rebuild_without_change_on_builder` as a build property. Update Trigger
to pass the property to triggered builds. Replace hardcoded builder name and
trigger checks in CompileWebKit, RunWebKitTests, ReRunWebKitTests, and
ReRunAPITests with property-based checks.
* Tools/CISupport/ews-build/steps_unittest.py: Add assertion for the new
`rebuild_without_change_on_builder` property in TestTrigger.test_defaults.
Canonical link: https://commits.webkit.org/306957@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
