Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: a38f196060a86ca7319bcd246d33e79078791ab4
https://github.com/WebKit/WebKit/commit/a38f196060a86ca7319bcd246d33e79078791ab4
Author: Brianna Fan <[email protected]>
Date: 2026-02-06 (Fri, 06 Feb 2026)
Changed paths:
M Tools/CISupport/Shared/steps.py
M Tools/CISupport/Shared/steps_unittest.py
M Tools/CISupport/build-webkit-org/factories.py
M Tools/CISupport/build-webkit-org/factories_unittest.py
M Tools/CISupport/build-webkit-org/steps.py
M Tools/CISupport/build-webkit-org/steps_unittest.py
Log Message:
-----------
[build.webkit.org] Support building and installing swift toolchain on workers
rdar://169221260
https://bugs.webkit.org/show_bug.cgi?id=306997
Reviewed by Aakash Jain.
Update BuildSwift to build the Swift toolchain.
Then, InstallSwiftToolchain will add it to ~/Library/Developer/Toolchains.
Then, InstallMetalToolchain checks for, installs, and links the metal toolchain.
Without this, our build will fail.
When we build and use the Swift toolchain, we no longer need to build a custom
clang, so we can remove these steps from the iOS Safer-CPP build.
This also updates PrintSwiftVersion to check for a toolchain installation
instead of the swift executable.
* Tools/CISupport/Shared/steps.py:
(PrintSwiftVersion.run):
(UpdateSwiftCheckouts):
(UpdateSwiftCheckouts.__init__):
(UpdateSwiftCheckouts.run):
(InstallSwiftToolchain):
(InstallSwiftToolchain.__init__):
(InstallSwiftToolchain.run):
(InstallSwiftToolchain.doStepIf):
(InstallSwiftToolchain.getResultSummary):
(InstallMetalToolchain):
(InstallMetalToolchain.__init__):
(InstallMetalToolchain.run):
(doStepIf):
(getResultSummary):
(UpdateClang.run):
* Tools/CISupport/Shared/steps_unittest.py:
(TestPrintSwiftVersion.test_success_with_tag_and_toolchain):
(TestPrintSwiftVersion.test_no_git_repository):
(TestPrintSwiftVersion.test_no_swift_toolchain):
(TestUpdateSwiftCheckouts.test_success):
(TestUpdateSwiftCheckouts.test_failure_with_previous_checkout):
(TestUpdateSwiftCheckouts.test_failure_without_previous_checkout):
(TestInstallSwiftToolchain):
(TestInstallSwiftToolchain.setUp):
(TestInstallSwiftToolchain.tearDown):
(TestInstallSwiftToolchain.configureStep):
(TestInstallSwiftToolchain.test_success):
(TestInstallSwiftToolchain.test_skipped_when_not_rebuilt):
(TestInstallSwiftToolchain.test_failure):
(TestInstallMetalToolchain):
(TestInstallMetalToolchain.setUp):
(TestInstallMetalToolchain.tearDown):
(TestInstallMetalToolchain.configureStep):
(TestInstallMetalToolchain.test_success_symlink_created):
(TestInstallMetalToolchain.test_success_symlink_already_exists):
(TestInstallMetalToolchain.test_failure):
(TestInstallMetalToolchain.test_success_installed):
(TestInstallMetalToolchain.test_skipped_when_not_rebuilt):
(TestPrintSwiftVersion.test_success_with_tag_and_executable): Deleted.
(TestPrintSwiftVersion.test_no_swift_executable): Deleted.
* Tools/CISupport/build-webkit-org/factories.py:
(SaferCPPStaticAnalyzerFactory.__init__):
- We no longer need to build custom clang with the Swift toolchain.
* Tools/CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/build-webkit-org/steps.py:
(ScanBuild.run):
(BuildSwift):
(BuildSwift.run):
(BuildSwift.getResultSummary):
(BuildSwift.doStepIf):
* Tools/CISupport/build-webkit-org/steps_unittest.py:
Canonical link: https://commits.webkit.org/306962@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
