Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: dd264a0bfdcb0975740f05223dff865e101b24c1
https://github.com/WebKit/WebKit/commit/dd264a0bfdcb0975740f05223dff865e101b24c1
Author: Aditya Keerthi <[email protected]>
Date: 2026-02-06 (Fri, 06 Feb 2026)
Changed paths:
M Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml
M Source/WebCore/platform/LocalizedStrings.cpp
M Source/WebCore/platform/LocalizedStrings.h
M Source/WebKit/DerivedSources-input.xcfilelist
M Source/WebKit/DerivedSources.make
A Source/WebKit/Shared/PDFDisplayMode.serialization.in
M Source/WebKit/UIProcess/PDF/WKPDFPageNumberIndicator.mm
M Source/WebKit/UIProcess/WebPageProxy.h
M Source/WebKit/UIProcess/WebPageProxy.messages.in
M Source/WebKit/UIProcess/WebPageProxyInternals.h
M Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm
M Source/WebKit/WebKit.xcodeproj/project.pbxproj
M Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/Plugins/PluginView.cpp
M Source/WebKit/WebProcess/Plugins/PluginView.h
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
M Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
Log Message:
-----------
[iOS] Add support for 2-up continuous mode for PDFs
https://bugs.webkit.org/show_bug.cgi?id=307176
rdar://169812226
Reviewed by Abrar Rahman Protyasha.
Add support for 2-up continuous mode for PDFs behind an off-by-default flag.
The display mode can be toggled using a menu accessible by tapping the page
number indicator. The option will be further restricted by size class in a
subsequent patch.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemPDFSinglePage):
(WebCore::contextMenuItemPDFTwoPages):
* Source/WebCore/platform/LocalizedStrings.h:
Move the "Single Page" and "Two Pages" strings out of `ENABLE(CONTEXT_MENU)`,
which is false on iOS.
* Source/WebKit/DerivedSources-input.xcfilelist:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/Shared/PDFDisplayMode.serialization.in: Added.
* Source/WebKit/UIProcess/PDF/WKPDFPageNumberIndicator.mm:
(-[WKPDFPageNumberIndicatorButton
contextMenuInteraction:willDisplayMenuForConfiguration:animator:]):
(-[WKPDFPageNumberIndicatorButton
contextMenuInteraction:willEndForConfiguration:animator:]):
(-[WKPDFPageNumberIndicator initWithFrame:view:pageCount:]):
(-[WKPDFPageNumberIndicator hide:]):
Do not hide the indicator if the menu is visible.
(-[WKPDFPageNumberIndicator _isSinglePage]):
(-[WKPDFPageNumberIndicator pdfPageNumberIndicatorButtonWillDisplayMenu:]):
(-[WKPDFPageNumberIndicator pdfPageNumberIndicatorButtonDidDismissMenu:]):
Restart the timer to hide the indicator after the menu is dismissed.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/WebPageProxy.messages.in:
* Source/WebKit/UIProcess/WebPageProxyInternals.h:
* Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:
`setPDFDisplayMode`/`requestPDFDisplayMode` are split into separate methods,
rather than using a completion handler, since the display mode can also be
changed directly in the web process via test-only methods.
(WebKit::WebPageProxy::pdfDisplayMode const):
(WebKit::WebPageProxy::setPDFDisplayMode):
(WebKit::WebPageProxy::requestPDFDisplayMode):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h:
(WebKit::PDFPluginBase::setDisplayModeAndUpdateLayout):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h:
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::setDisplayMode):
* Source/WebKit/WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::setPDFDisplayMode):
* Source/WebKit/WebProcess/Plugins/PluginView.h:
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
* Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setPDFDisplayMode):
(WebKit::WebPage::requestPDFDisplayMode):
Canonical link: https://commits.webkit.org/306982@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
