Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 2ebfc079030081bd40f425e5a434c8f64d4406cb
https://github.com/WebKit/WebKit/commit/2ebfc079030081bd40f425e5a434c8f64d4406cb
Author: Alex Christensen <[email protected]>
Date: 2026-02-07 (Sat, 07 Feb 2026)
Changed paths:
M Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp
M Source/WebKit/WebProcess/Network/WebTransportSession.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.h
M Source/WebKit/WebProcess/WebProcess.cpp
M Source/WebKit/WebProcess/WebProcess.h
Log Message:
-----------
Remove release assert in WebTransportSession constructor
https://bugs.webkit.org/show_bug.cgi?id=307216
rdar://168599027
Reviewed by Tim Nguyen.
The assertion fires when a WebTransportSession is created in a service worker
in a process that has not seen a WebPage with WebTransport enabled.
The checks are no longer needed or useful because WebTransport is enabled by
default everywhere where COMPLETE_WEB_TRANSPORT is on.
The assertion could be hit by running WebTransport tests multiple times:
run-webkit-tests --iterations 10
LayoutTests/imported/w3c/web-platform-tests/webtransport
...
imported/w3c/web-platform-tests/webtransport/idlharness.https.any.serviceworker.html
failed unexpectedly (ServiceWorkerProcess crashed [pid=81833])
Many thanks to David Kilzer for assistance in analyzing this bug.
* Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::dispatchMessage):
* Source/WebKit/WebProcess/Network/WebTransportSession.cpp:
(WebKit::WebTransportSession::WebTransportSession):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::isWebTransportEnabled const): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::removeWebPage):
(WebKit::WebProcess::updateIsWebTransportEnabled): Deleted.
* Source/WebKit/WebProcess/WebProcess.h:
Canonical link: https://commits.webkit.org/307004@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
