Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 4af680358f82030d8ff29069f1a3d98d367a7b01
https://github.com/WebKit/WebKit/commit/4af680358f82030d8ff29069f1a3d98d367a7b01
Author: Gerald Squelart <[email protected]>
Date: 2026-02-08 (Sun, 08 Feb 2026)
Changed paths:
M
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
M Source/WebCore/platform/graphics/FontCascadeFonts.h
M Source/WebCore/style/InlineTextBoxStyle.cpp
M Source/WebCore/style/InlineTextBoxStyle.h
Log Message:
-----------
inkOverflowForDecorations() should use its own return type
https://bugs.webkit.org/show_bug.cgi?id=307281
rdar://169927130
Reviewed by Cameron McCormack.
inkOverflowForDecorations() was using GlyphOverflow as output, but it
doesn't share code paths with other users of GlyphOverflow going through
FontCascade::width(), and it doesn't need the `computeBounds` member.
Instead it now returns its own data type, based on RectEdge<LayoutUnit>,
with some helper member functions stolen from GlyphOverflow.
Also some unused code was removed.
*
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::collectInkOverflowForTextDecorations):
* Source/WebCore/platform/graphics/FontCascadeFonts.h:
(WebCore::GlyphOverflow::isEmpty const): Deleted.
(WebCore::GlyphOverflow::extendTo): Deleted.
(WebCore::GlyphOverflow::extendTop): Deleted.
(WebCore::GlyphOverflow::extendBottom): Deleted.
(WebCore::GlyphOverflow::operator!=): Deleted.
* Source/WebCore/style/InlineTextBoxStyle.cpp:
(WebCore::computedUnderlineOffset):
(WebCore::computedInkOverflowForDecorations):
(WebCore::inkOverflowForDecorations):
(WebCore::enclosingRendererWithTextDecoration): Deleted.
(WebCore::textRunOffsetFromBottomMost): Deleted.
* Source/WebCore/style/InlineTextBoxStyle.h:
(WebCore::InkOverflowForDecorations::extendTop):
(WebCore::InkOverflowForDecorations::extendBottom):
Canonical link: https://commits.webkit.org/307046@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
