Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 00a7e8b31f8ab6844b71086b9f9aadce2702b99e
https://github.com/WebKit/WebKit/commit/00a7e8b31f8ab6844b71086b9f9aadce2702b99e
Author: Youenn Fablet <[email protected]>
Date: 2026-02-09 (Mon, 09 Feb 2026)
Changed paths:
M Source/WebCore/Modules/streams/ReadableByteStreamController.cpp
M Source/WebCore/Modules/streams/ReadableByteStreamController.h
M Source/WebCore/Modules/streams/ReadableStream.cpp
M Source/WebCore/Modules/streams/ReadableStream.h
M Source/WebCore/Modules/streams/ReadableStream.idl
Log Message:
-----------
Make ReadableStream an ActiveDOMObject
rdar://169765188
https://bugs.webkit.org/show_bug.cgi?id=307314
Reviewed by Chris Dumez.
We were forgetting to mark the pull and cancel algorithms, which is in most
cases handled by marking the underlying source, but not always.
Also, we were not setting the underlying source, like it should. We are now
doing so, using the owner as the globalObject.
To properly clear the underlying source, like done for JSDOMGuardedObject, we
make ReadableStream an active dom object and clear the underlying source when
the stream gets stopped.
For good measure, we also clear the pull and cancel callbacks at the same time.
Covered by existing tests.
Canonical link: https://commits.webkit.org/307076@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
