Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: cd6feb8d6a6d6d026fe0949f65f3893a16a72421
https://github.com/WebKit/WebKit/commit/cd6feb8d6a6d6d026fe0949f65f3893a16a72421
Author: Qianlang Chen <[email protected]>
Date: 2026-02-09 (Mon, 09 Feb 2026)
Changed paths:
M LayoutTests/http/tests/site-isolation/inspector/target/target.html
A
LayoutTests/http/tests/site-isolation/inspector/unit-tests/target-manager-expected.txt
A
LayoutTests/http/tests/site-isolation/inspector/unit-tests/target-manager.html
A LayoutTests/http/tests/site-isolation/inspector/worker/resources
M LayoutTests/inspector/unit-tests/target-manager-expected.txt
M LayoutTests/inspector/unit-tests/target-manager.html
M LayoutTests/platform/mac-site-isolation/TestExpectations
M Source/WebInspectorUI/UserInterface/Test/Test.js
M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp
M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h
M Source/WebKit/UIProcess/WebFrameProxy.cpp
Log Message:
-----------
[Site Isolation] Web Inspector: Only vend frame targets to frontend with site
isolation on
rdar://169309429
https://bugs.webkit.org/show_bug.cgi?id=306822
Reviewed by BJ Burg.
Our work that attempted to implement the console domain in frame targets
while removing from page targets revealed a compatibility issue that
old inspector frontends can't smoothly inspect new backends with
features routed through frame targets.
Reduce the scope of this issue by hiding our site isolation work behind
the site isolation setting, preserving the old behavior with the single
page target architecture. The plan now is to resume implementing agents
in frame targets behind the setting while still keeping the page target
for legacy frontend support.
*
LayoutTests/http/tests/site-isolation/inspector/unit-tests/target-manager-expected.txt:
Copied from LayoutTests/inspector/unit-tests/target-manager-expected.txt.
*
LayoutTests/http/tests/site-isolation/inspector/unit-tests/target-manager.html:
Copied from LayoutTests/inspector/unit-tests/target-manager.html.
* LayoutTests/http/tests/site-isolation/inspector/worker/resources: Added.
* LayoutTests/inspector/unit-tests/target-manager-expected.txt:
* LayoutTests/inspector/unit-tests/target-manager.html:
* Source/WebInspectorUI/UserInterface/Test/Test.js:
Update the target-manager.html test to be able to work with either SI
or non-SI backend, as both are well-defined behavior now. Only expect
frame targets when SI is enabled.
Copy the test case into the site-isolation directory, so it can run with
SI enabled and store separate results.
* LayoutTests/http/tests/site-isolation/inspector/target/target.html:
* LayoutTests/platform/mac-site-isolation/TestExpectations:
Fix the target.html test by adding the SiteIsolationEnabled=true comment
at the top, which forces it to be run under site isolation. (The
--site-isolation flag runs a comparison test which was not what we
wanted. This test won't pass without SI off as no frame targets are
announced.)
* Source/WebKit/UIProcess/Inspector/WebPageInspectorController.cpp:
(WebKit::WebPageInspectorController::didCreateFrame):
(WebKit::WebPageInspectorController::willDestroyFrame):
(WebKit::WebPageInspectorController::createWebFrameInspectorTarget): Deleted.
* Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h:
* Source/WebKit/UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::~WebFrameProxy):
(WebKit::WebFrameProxy::webProcessWillShutDown):
Create frame targets only conditionally.
Canonical link: https://commits.webkit.org/307133@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
