Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 54ff3284a638412efdbdd730b3a91d5fb77d0545
https://github.com/WebKit/WebKit/commit/54ff3284a638412efdbdd730b3a91d5fb77d0545
Author: Tim Nguyen <[email protected]>
Date: 2026-02-09 (Mon, 09 Feb 2026)
Changed paths:
M LayoutTests/TestExpectations
M
LayoutTests/fast/forms/appearance-base/internal-auto-base-function-expected.html
M LayoutTests/fast/forms/appearance-base/internal-auto-base-function.html
M Source/WebCore/html/HTMLSelectElement.cpp
M Source/WebCore/style/StyleChange.cpp
Log Message:
-----------
Stop using `RenderMenuList` when `appearance: base` is set
https://bugs.webkit.org/show_bug.cgi?id=307131
rdar://169766844
Reviewed by Alan Baradlay.
We don't want the sizing quirks of RenderMenuList when appearance: base is used.
RenderMenuList is also forces the box to be a RenderFlexibleBox regardless of
the CSS display value, which is generally unwanted for appearance: base.
* LayoutTests/TestExpectations:
*
LayoutTests/fast/forms/appearance-base/internal-auto-base-function-expected.html:
* LayoutTests/fast/forms/appearance-base/internal-auto-base-function.html:
* Source/WebCore/html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::createElementRenderer):
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): This is to
dynamically update the width of the renderer, which is only relevant for
RenderListBox & RenderMenuList.
* Source/WebCore/style/StyleChange.cpp:
(WebCore::Style::determineChanges):
Canonical link: https://commits.webkit.org/307136@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
