Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 3d45824fb8d45b3b3d197dc2ba03e665831535de
https://github.com/WebKit/WebKit/commit/3d45824fb8d45b3b3d197dc2ba03e665831535de
Author: Chris Dumez <[email protected]>
Date: 2026-02-09 (Mon, 09 Feb 2026)
Changed paths:
M Source/WebCore/Modules/applepay/ApplePaySession.cpp
M Source/WebCore/Modules/applepay/ApplePaySetup.cpp
M Source/WebCore/Modules/cookie-store/CookieStore.cpp
M Source/WebCore/Modules/webaudio/AudioContext.cpp
M Source/WebCore/dom/BroadcastChannel.cpp
M Source/WebCore/dom/Document.cpp
M Source/WebCore/dom/DocumentFullscreen.cpp
M Source/WebCore/history/CachedFrame.cpp
M Source/WebCore/history/CachedPage.cpp
M Source/WebCore/html/HTMLVideoElement.cpp
M Source/WebCore/html/parser/HTMLDocumentParser.cpp
M Source/WebCore/inspector/CommandLineAPIHost.cpp
M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
M Source/WebCore/loader/DocumentLoader.cpp
M Source/WebCore/loader/DocumentThreadableLoader.cpp
M Source/WebCore/loader/FrameLoader.cpp
M Source/WebCore/loader/ResourceTimingInformation.cpp
M Source/WebCore/loader/SubframeLoader.cpp
M Source/WebCore/loader/cache/CachedResourceLoader.cpp
M Source/WebCore/page/ContextMenuController.cpp
M Source/WebCore/page/DebugPageOverlays.cpp
M Source/WebCore/page/FocusController.cpp
M Source/WebCore/page/Frame.cpp
M Source/WebCore/page/Frame.h
M Source/WebCore/page/FrameTree.cpp
M Source/WebCore/page/FrameTree.h
M Source/WebCore/page/FrameView.cpp
M Source/WebCore/page/FrameView.h
M Source/WebCore/page/History.cpp
M Source/WebCore/page/LargestContentfulPaintData.cpp
M Source/WebCore/page/LocalDOMWindow.cpp
M Source/WebCore/page/LocalDOMWindow.h
M Source/WebCore/page/LocalFrame.cpp
M Source/WebCore/page/LocalFrame.h
M Source/WebCore/page/LocalFrameInlines.h
M Source/WebCore/page/LocalFrameView.cpp
M Source/WebCore/page/LocalFrameView.h
M Source/WebCore/page/LocalFrameViewLayoutContext.cpp
M Source/WebCore/page/LocalFrameViewLayoutContext.h
M Source/WebCore/page/Location.cpp
M Source/WebCore/page/Navigation.cpp
M Source/WebCore/page/Page.cpp
M Source/WebCore/page/Page.h
M Source/WebCore/page/PageColorSampler.cpp
M Source/WebCore/page/PageOverlay.cpp
M Source/WebCore/page/PageOverlay.h
M Source/WebCore/page/RemoteDOMWindow.cpp
M Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp
M Source/WebCore/plugins/PluginData.cpp
M Source/WebCore/rendering/RenderLayerCompositor.cpp
M Source/WebCore/rendering/RenderView.cpp
M Source/WebCore/testing/Internals.cpp
M Source/WebCore/testing/MockPaymentCoordinator.cpp
M Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp
M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp
M Source/WebKit/WebProcess/Inspector/WebFrameInspectorTarget.cpp
M Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp
M
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm
M Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm
M Source/WebKit/WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm
M Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm
M Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm
M Source/WebKit/WebProcess/WebPage/FindController.cpp
M Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp
M Source/WebKit/WebProcess/WebPage/WebFrame.cpp
M Source/WebKit/WebProcess/WebPage/WebPage.cpp
M Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp
M Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm
M Source/WebKitLegacy/WebCoreSupport/LegacyWebPageInspectorController.cpp
M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
Log Message:
-----------
Reduce use of protected functions in Source/WebCore/page
https://bugs.webkit.org/show_bug.cgi?id=307329
Reviewed by Anne van Kesteren.
* Source/WebCore/Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::supportsVersion):
(WebCore::ApplePaySession::canMakePayments):
(WebCore::ApplePaySession::canMakePaymentsWithActiveCard):
(WebCore::ApplePaySession::openPaymentSetup):
* Source/WebCore/Modules/applepay/ApplePaySetup.cpp:
(WebCore::ApplePaySetup::getSetupFeatures):
(WebCore::ApplePaySetup::begin):
(WebCore::ApplePaySetup::stop):
* Source/WebCore/Modules/cookie-store/CookieStore.cpp:
(WebCore::CookieStore::stop):
* Source/WebCore/Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::getOutputTimestamp):
* Source/WebCore/dom/BroadcastChannel.cpp:
(WebCore::BroadcastChannel::MainThreadBridge::registerChannel):
(WebCore::BroadcastChannel::MainThreadBridge::unregisterChannel):
(WebCore::BroadcastChannel::MainThreadBridge::postMessage):
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::attachToCachedFrame):
(WebCore::Document::open):
(WebCore::Document::implicitClose):
(WebCore::Document::navigateFromServiceWorker):
* Source/WebCore/dom/DocumentFullscreen.cpp:
(WebCore::DocumentFullscreen::didExitFullscreen):
* Source/WebCore/history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
(WebCore::CachedFrame::open):
* Source/WebCore/history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
* Source/WebCore/html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::serviceRequestVideoFrameCallbacks):
* Source/WebCore/html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizerLoop):
* Source/WebCore/inspector/CommandLineAPIHost.cpp:
(WebCore::instrumentingAgentsForGlobalObject):
* Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorBackendDispatchTask::dispatchOneMessage):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):
* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::notifyFinished):
(WebCore::DocumentLoader::responseReceived):
(WebCore::DocumentLoader::commitData):
* Source/WebCore/loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::setDefersLoading):
(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::didOpenURL):
(WebCore::FrameLoader::didExplicitOpen):
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::checkCompleted):
(WebCore::FrameLoader::provisionalLoadStarted):
(WebCore::FrameLoader::completed):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::stopForBackForwardCache):
(WebCore::FrameLoader::willRestoreFromCachedPage):
(WebCore::FrameLoader::navigatorPlatform const):
(WebCore::FrameLoader::scheduleRefreshIfNeeded):
* Source/WebCore/loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
* Source/WebCore/loader/SubframeLoader.cpp:
(WebCore::FrameLoader::SubframeLoader::loadOrRedirectSubframe):
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestResource):
* Source/WebCore/page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* Source/WebCore/page/DebugPageOverlays.cpp:
(WebCore::InteractionRegionOverlay::rectForSettingAtIndex const):
* Source/WebCore/page/FocusController.cpp:
(WebCore::FocusController::setFocusedInternal):
* Source/WebCore/page/Frame.cpp:
(WebCore::Frame::~Frame):
(WebCore::Frame::updateFrameTreeSyncData):
(WebCore::Frame::protectedWindowProxy const): Deleted.
(WebCore::Frame::protectedNavigationScheduler const): Deleted.
(WebCore::Frame::protectedTopOrigin const): Deleted.
* Source/WebCore/page/Frame.h:
(WebCore::Frame::windowProxy const):
(WebCore::Frame::mainFrame const):
(WebCore::Frame::navigationScheduler const):
(WebCore::Frame::frameTreeSyncData const):
(WebCore::Frame::protectedMainFrame): Deleted.
(WebCore::Frame::protectedMainFrame const): Deleted.
(WebCore::Frame::protectedFrameTreeSyncData const): Deleted.
* Source/WebCore/page/FrameTree.cpp:
(showFrameTree):
(WebCore::FrameTree::protectedTop const): Deleted.
* Source/WebCore/page/FrameTree.h:
* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::scrollableAreaBoundingBox const):
(WebCore::FrameView::convertToContainingView const):
(WebCore::FrameView::convertFromContainingView const):
(WebCore::FrameView::protectedFrame const): Deleted.
* Source/WebCore/page/FrameView.h:
* Source/WebCore/page/History.cpp:
(WebCore::History::go):
* Source/WebCore/page/LargestContentfulPaintData.cpp:
(WebCore::LargestContentfulPaintData::potentiallyAddLargestContentfulPaintEntry):
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::setLocation):
(WebCore::LocalDOMWindow::createWindow):
(WebCore::LocalDOMWindow::open):
(WebCore::LocalDOMWindow::protectedPerformance const): Deleted.
* Source/WebCore/page/LocalDOMWindow.h:
* Source/WebCore/page/LocalFrame.cpp:
(WebCore::LocalFrame::clearTimers):
(WebCore::LocalFrame::protectedInspectorController const): Deleted.
* Source/WebCore/page/LocalFrame.h:
* Source/WebCore/page/LocalFrameInlines.h:
(WebCore::LocalFrame::protectedEditor): Deleted.
(WebCore::LocalFrame::protectedEditor const): Deleted.
* Source/WebCore/page/LocalFrameView.cpp:
(WebCore::LocalFrameView::protectedFrame const): Deleted.
* Source/WebCore/page/LocalFrameView.h:
* Source/WebCore/page/LocalFrameViewLayoutContext.cpp:
(WebCore::LocalFrameViewLayoutContext::protectedView const): Deleted.
* Source/WebCore/page/LocalFrameViewLayoutContext.h:
* Source/WebCore/page/Location.cpp:
(WebCore::Location::reload):
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::performTraversal):
* Source/WebCore/page/Page.cpp:
(WebCore::m_mediaSessionManagerFactory):
(WebCore::Page::~Page):
(WebCore::Page::viewportArguments const):
(WebCore::Page::refreshPlugins):
(WebCore::Page::screenPropertiesDidChange):
(WebCore::Page::windowScreenDidChange):
(WebCore::Page::lockAllOverlayScrollbarsToHidden):
(WebCore::Page::setVerticalScrollElasticity):
(WebCore::Page::renderingUpdateCompleted):
(WebCore::Page::advancedPrivacyProtections const):
(WebCore::Page::forEachDocument const):
(WebCore::Page::reloadExecutionContextsForOrigin const):
(WebCore::Page::requiresScriptTrackingPrivacyProtections const):
(WebCore::Page::requiresUserGestureForAudioPlayback const):
(WebCore::Page::requiresUserGestureForVideoPlayback const):
(WebCore::Page::protectedMainFrameOrigin const): Deleted.
(WebCore::Page::protectedBroadcastChannelRegistry const): Deleted.
(WebCore::Page::protectedMainFrame const): Deleted.
(WebCore::Page::protectedOpportunisticTaskScheduler const): Deleted.
(WebCore::Page::protectedCookieJar const): Deleted.
(WebCore::Page::protectedStorageNamespaceProvider const): Deleted.
(WebCore::Page::protectedPluginInfoProvider const): Deleted.
(WebCore::Page::protectedPaymentCoordinator const): Deleted.
* Source/WebCore/page/Page.h:
(WebCore::Page::opportunisticTaskScheduler const):
(WebCore::Page::mainFrame const):
(WebCore::Page::broadcastChannelRegistry):
(WebCore::Page::paymentCoordinator const):
(WebCore::Page::cookieJar):
(WebCore::Page::storageNamespaceProvider):
* Source/WebCore/page/PageColorSampler.cpp:
(WebCore::sampleColor):
* Source/WebCore/page/PageOverlay.cpp:
(WebCore::PageOverlay::bounds const):
(WebCore::PageOverlay::viewToOverlayOffset const):
(WebCore::PageOverlay::drawRect):
(WebCore::PageOverlay::mouseEvent):
(WebCore::PageOverlay::protectedLayer const): Deleted.
* Source/WebCore/page/PageOverlay.h:
* Source/WebCore/page/RemoteDOMWindow.cpp:
(WebCore::RemoteDOMWindow::setLocation):
* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewEventTrackingRegionsChanged):
* Source/WebCore/plugins/PluginData.cpp:
(WebCore::PluginData::initPlugins):
(WebCore::PluginData::webVisiblePlugins const):
(WebCore::PluginData::supportsWebVisibleMimeTypeForURL const):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::attachRootLayer):
(WebCore::RenderLayerCompositor::detachRootLayer):
* Source/WebCore/rendering/RenderView.cpp:
(WebCore::RenderView::shouldUsePrintingLayout const):
* Source/WebCore/testing/Internals.cpp:
(WebCore::InspectorStubFrontend::InspectorStubFrontend):
* Source/WebCore/testing/MockPaymentCoordinator.cpp:
(WebCore::MockPaymentCoordinator::showPaymentUI):
(WebCore::MockPaymentCoordinator::completeMerchantValidation):
(WebCore::MockPaymentCoordinator::changeShippingOption):
(WebCore::MockPaymentCoordinator::changePaymentMethod):
(WebCore::MockPaymentCoordinator::changeCouponCode):
(WebCore::MockPaymentCoordinator::acceptPayment):
(WebCore::MockPaymentCoordinator::cancelPayment):
* Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::getCookiesForFrame):
(WebKit::WebAutomationSessionProxy::deleteCookie):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::enterFullScreenForElement):
* Source/WebKit/WebProcess/Inspector/WebFrameInspectorTarget.cpp:
(WebKit::WebFrameInspectorTarget::connect):
(WebKit::WebFrameInspectorTarget::disconnect):
(WebKit::WebFrameInspectorTarget::sendMessageToTargetBackend):
* Source/WebKit/WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
*
Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/PDFDataDetectorOverlayController.mm:
(WebKit::PDFDataDetectorOverlayController::handleMouseEvent):
* Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm:
(WebKit::UnifiedPDFPlugin::takeFindStringFromSelection):
(WebKit::UnifiedPDFPlugin::forwardEditingCommandToEditor const):
* Source/WebKit/WebProcess/WebCoreSupport/ShareableBitmapUtilities.cpp:
(WebKit::createShareableBitmap):
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::searchWithGoogle):
* Source/WebKit/WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertDragImageToBitmap):
* Source/WebKit/WebProcess/WebPage/Cocoa/WebPageCocoa.mm:
(WebKit::WebPage::insertDictatedTextAsync):
(WebKit::WebPage::getPlatformEditorStateCommon const):
(WebKit::WebPage::replaceImageForRemoveBackground):
(WebKit::WebPage::readSelectionFromPasteboard):
(WebKit::WebPage::handleAlternativeTextUIResult):
(WebKit::WebPage::setTextAsync):
(WebKit::WebPage::getMarkedRangeAsync):
(WebKit::WebPage::getSelectedRangeAsync):
(WebKit::WebPage::firstRectForCharacterRangeAsync):
(WebKit::WebPage::setCompositionAsync):
(WebKit::WebPage::setWritingSuggestion):
(WebKit::WebPage::confirmCompositionAsync):
(WebKit::WebPage::insertTextPlaceholder):
(WebKit::WebPage::removeTextPlaceholder):
* Source/WebKit/WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::rectsForTextMatchesInRect):
* Source/WebKit/WebProcess/WebPage/WebFoundTextRangeController.cpp:
(WebKit::WebFoundTextRangeController::replaceFoundTextRangeWithString):
(WebKit::WebFoundTextRangeController::addLayerForFindOverlay):
* Source/WebKit/WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::selectionAsString const):
(WebKit::WebFrame::setTextDirection):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::m_isPopup):
(WebKit::WebPage::changeFontAttributes):
(WebKit::WebPage::changeFont):
(WebKit::WebPage::executeEditingCommand):
(WebKit::WebPage::setEditable):
(WebKit::WebPage::increaseListLevel):
(WebKit::WebPage::decreaseListLevel):
(WebKit::WebPage::changeListType):
(WebKit::WebPage::setBaseWritingDirection):
(WebKit::WebPage::setSize):
(WebKit::WebPage::didScaleView):
(WebKit::snapshotColorSpace):
(WebKit::WebPage::pageDidScroll):
(WebKit::WebPage::validateCommand):
(WebKit::WebPage::requestFontAttributesAtSelectionStart):
(WebKit::WebPage::insertNewlineInQuotedContent):
(WebKit::WebPage::copyLinkWithHighlight):
(WebKit::WebPage::detectDataInAllFrames):
(WebKit::WebPage::advanceToNextMisspelling):
(WebKit::WebPage::uppercaseWord):
(WebKit::WebPage::lowercaseWord):
(WebKit::WebPage::capitalizeWord):
(WebKit::WebPage::convertToTraditionalChinese):
(WebKit::WebPage::convertToSimplifiedChinese):
(WebKit::WebPage::replaceSelectionWithText):
(WebKit::WebPage::cancelComposition):
(WebKit::WebPage::setAlwaysShowsHorizontalScroller):
(WebKit::WebPage::setAlwaysShowsVerticalScroller):
(WebKit::WebPage::insertAttachment):
(WebKit::WebPage::updateLastNodeBeforeWritingSuggestions):
* Source/WebKit/WebProcess/WebPage/WebPageTesting.cpp:
(WebKit::WebPageTesting::isEditingCommandEnabled):
* Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::getPlatformEditorState const):
(WebKit::WebPage::handleAcceptedCandidate):
(WebKit::WebPage::getStringSelectionForPasteboard):
(WebKit::WebPage::getDataSelectionForPasteboard):
* Source/WebKitLegacy/WebCoreSupport/LegacyWebPageInspectorController.cpp:
* Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
Canonical link: https://commits.webkit.org/307148@main
To unsubscribe from these emails, change your notification settings at
https://github.com/WebKit/WebKit/settings/notifications
